mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
9ad8b4d393
Instances coming from different VM contexts don't pass `instanceof` type checks because each context has its own copy of the built-in globals. After review of the relevant code it seems like it should be safe to relax the type check and that is what this commit does: `wasi.start()` now accepts any input that walks and quacks like a WebAssembly.Instance or WebAssembly.Memory instance. Fixes: https://github.com/nodejs/node/issues/33415 PR-URL: https://github.com/nodejs/node/pull/33431 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> |
||
|---|---|---|
| .. | ||
| c | ||
| wasm | ||
| Makefile | ||
| README.md | ||
| test-return-on-exit.js | ||
| test-wasi-not-started.js | ||
| test-wasi-options-validation.js | ||
| test-wasi-require-flag.js | ||
| test-wasi-start-validation.js | ||
| test-wasi-symlinks.js | ||
| test-wasi.js | ||
| testcfg.py | ||
| wasi.status | ||
WASI Tests
Compile with clang and wasm32-wasi target. The clang version used must be
built with wasi-libc. You can specify the location for clang and the sysroot
if needed when running make:
$ make CC=/usr/local/opt/llvm/bin/clang SYSROOT=/path/to/wasi-libc/sysroot