mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
7e5e1c2515
The tests still fail after being split into multiple files, (2 out of 30 runs in roughly 48 hours) and the causes are missing target frames in the samples. This patch moves them to sequential to observe if the flakiness can be fixed when the tests are run on a system with less load. If the flake ever shows up again even after the tests are moved to sequential, we should consider make the test conditions more lenient - that is, we would only assert that there are *some* frames in the generated CPU profile but do not look for the target function there. PR-URL: https://github.com/nodejs/node/pull/28210 Refs: https://github.com/nodejs/node/issues/27611 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
37 lines
982 B
JavaScript
37 lines
982 B
JavaScript
'use strict';
|
|
|
|
// Test --cpu-prof without --cpu-prof-interval. Here we just verify that
|
|
// we manage to generate a profile since it's hard to tell whether we
|
|
// can sample our target function with the default sampling rate across
|
|
// different platforms and machine configurations.
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const assert = require('assert');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
const {
|
|
getCpuProfiles,
|
|
env
|
|
} = require('../common/cpu-prof');
|
|
|
|
{
|
|
tmpdir.refresh();
|
|
const output = spawnSync(process.execPath, [
|
|
'--cpu-prof',
|
|
fixtures.path('workload', 'fibonacci.js'),
|
|
], {
|
|
cwd: tmpdir.path,
|
|
env
|
|
});
|
|
if (output.status !== 0) {
|
|
console.log(output.stderr.toString());
|
|
}
|
|
assert.strictEqual(output.status, 0);
|
|
const profiles = getCpuProfiles(tmpdir.path);
|
|
assert.strictEqual(profiles.length, 1);
|
|
}
|