mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
7f496fefb6
`Environment::GetCurrent` may not available in the context of OOM. Removes the cyclic `Environment::GetCurrent` and `env->isolate()` calls to ensure both `isolate` and `env` is present if available. However, this behavior is not guaranteed. As `Environment::GetCurrent` didn't allocate new handles in the heap, when a Context is entered it can still get the valid env pointer. Removes the unstable assertion of the absence of env in the test. PR-URL: https://github.com/nodejs/node/pull/44398 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
43 lines
1.3 KiB
JavaScript
43 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
// Testcases for situations involving fatal errors, like Javascript heap OOM
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
const helper = require('../common/report.js');
|
|
const spawnSync = require('child_process').spawnSync;
|
|
const tmpdir = require('../common/tmpdir');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
// Common args that will cause an out-of-memory error for child process.
|
|
const ARGS = [
|
|
'--max-heap-size=20',
|
|
fixtures.path('report-oom'),
|
|
];
|
|
const REPORT_FIELDS = [
|
|
['header.trigger', 'OOMError'],
|
|
['javascriptHeap.memoryLimit', 20 * 1024 * 1024 /* 20MB */],
|
|
];
|
|
|
|
{
|
|
// Verify that --report-compact is respected when set.
|
|
// Verify that --report-filename is respected when set.
|
|
tmpdir.refresh();
|
|
const args = [
|
|
'--report-on-fatalerror',
|
|
'--report-compact',
|
|
'--report-filename=stderr',
|
|
...ARGS,
|
|
];
|
|
const child = spawnSync(process.execPath, args, { encoding: 'utf8' });
|
|
assert.notStrictEqual(child.status, 0, 'Process exited unexpectedly');
|
|
|
|
const reports = helper.findReports(child.pid, tmpdir.path);
|
|
assert.strictEqual(reports.length, 0);
|
|
|
|
const lines = child.stderr.split('\n');
|
|
// Skip over unavoidable free-form output and gc log from V8.
|
|
const report = lines.find((i) => i.startsWith('{'));
|
|
helper.validateContent(report, REPORT_FIELDS);
|
|
}
|