node/test/async-hooks/test-filehandle-no-reuse.js
Gerhard Stoebich c145b29987
async_hooks: avoid resource reuse by FileHandle
Wrap reused read_wrap in a unique async resource to ensure that
executionAsyncResource() is not ambiguous.

PR-URL: https://github.com/nodejs/node/pull/31972
Refs: https://github.com/nodejs/node/pull/30959
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2020-03-11 19:26:10 +01:00

66 lines
1.8 KiB
JavaScript

'use strict';
const common = require('../common');
const initHooks = require('./init-hooks');
const { checkInvocations } = require('./hook-checks');
const fixtures = require('../common/fixtures');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const fs = require('fs');
// Checks that the async resource is not reused by FileHandle.
// Test is based on parallel\test-http2-respond-file-fd.js.
const hooks = initHooks();
hooks.enable();
const {
HTTP2_HEADER_CONTENT_TYPE
} = http2.constants;
// Use large fixture to get several file operations.
const fname = fixtures.path('person-large.jpg');
const fd = fs.openSync(fname, 'r');
const server = http2.createServer();
server.on('stream', (stream) => {
stream.respondWithFD(fd, {
[HTTP2_HEADER_CONTENT_TYPE]: 'text/plain'
});
});
server.on('close', common.mustCall(() => fs.closeSync(fd)));
server.listen(0, () => {
const client = http2.connect(`http://localhost:${server.address().port}`);
const req = client.request();
req.on('response', common.mustCall());
req.on('data', () => {});
req.on('end', common.mustCall(() => {
client.close();
server.close();
}));
req.end();
});
process.on('exit', onExit);
function onExit() {
hooks.disable();
hooks.sanityCheck();
const activities = hooks.activities;
// Verify both invocations
const fsReqs = activities.filter((x) => x.type === 'FSREQCALLBACK');
assert.ok(fsReqs.length >= 2);
checkInvocations(fsReqs[0], { init: 1, destroy: 1 }, 'when process exits');
checkInvocations(fsReqs[1], { init: 1, destroy: 1 }, 'when process exits');
// Verify reuse handle has been wrapped
assert.ok(fsReqs[0].handle !== fsReqs[1].handle, 'Resource reused');
assert.ok(fsReqs[0].handle === fsReqs[1].handle.handle,
'Resource not wrapped correctly');
}