mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
7cb3a662da
When a ESM module cannot be loaded by require due to the presence of TLA, its module status would be stopped at kInstantiated. In this case, when it's imported again, we should allow it to be evaluated asynchronously, as it's also a common pattern for users to retry with dynamic import when require fails. PR-URL: https://github.com/nodejs/node/pull/55502 Fixes: https://github.com/nodejs/node/issues/55500 Refs: https://github.com/nodejs/node/issues/52697 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
33 lines
1.2 KiB
JavaScript
33 lines
1.2 KiB
JavaScript
// This tests that after failing to require an ESM that contains TLA,
|
|
// retrying with import() still works, and produces consistent results.
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { exportedResolve } = require('../fixtures/es-modules/tla/export-promise.mjs');
|
|
|
|
assert.throws(() => {
|
|
require('../fixtures/es-modules/tla/await-export-promise.mjs');
|
|
}, {
|
|
code: 'ERR_REQUIRE_ASYNC_MODULE'
|
|
});
|
|
|
|
const interval = setInterval(() => {}, 1000); // Keep the test running, because await alone doesn't.
|
|
const value = { hello: 'world' };
|
|
|
|
const p1 = import('../fixtures/es-modules/tla/await-export-promise.mjs').then(common.mustCall((ns) => {
|
|
assert.strictEqual(ns.default, value);
|
|
}), common.mustNotCall());
|
|
|
|
const p2 = import('../fixtures/es-modules/tla/await-export-promise.mjs').then(common.mustCall((ns) => {
|
|
assert.strictEqual(ns.default, value);
|
|
}), common.mustNotCall());
|
|
|
|
const p3 = import('../fixtures/es-modules/tla/await-export-promise.mjs').then(common.mustCall((ns) => {
|
|
assert.strictEqual(ns.default, value);
|
|
}), common.mustNotCall());
|
|
|
|
exportedResolve(value);
|
|
|
|
Promise.all([p1, p2, p3]).then(common.mustCall(() => { clearInterval(interval); }));
|