mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
242bfb6bfc
Add a flag that allows for the setting of a directory where all diagnostic output will be written to. e.g. --redirect-warnings Refs: https://github.com/nodejs/node/pull/33010#issuecomment-618544792 PR-URL: https://github.com/nodejs/node/pull/33584 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
118 lines
3.0 KiB
JavaScript
118 lines
3.0 KiB
JavaScript
'use strict';
|
|
|
|
// This test is to ensure that --diagnostic-dir does not change the directory
|
|
// for --cpu-prof when --cpu-prof-dir is specified
|
|
|
|
const common = require('../common');
|
|
const fixtures = require('../common/fixtures');
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const assert = require('assert');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const { spawnSync } = require('child_process');
|
|
|
|
const tmpdir = require('../common/tmpdir');
|
|
|
|
function findFirstFrameInNode(root, func) {
|
|
const first = root.children.find(
|
|
(child) => child.callFrame.functionName === func
|
|
);
|
|
if (first) {
|
|
return first;
|
|
}
|
|
for (const child of root.children) {
|
|
const first = findFirstFrameInNode(child, func);
|
|
if (first) {
|
|
return first;
|
|
}
|
|
}
|
|
return undefined;
|
|
}
|
|
|
|
function findFirstFrame(file, func) {
|
|
const data = fs.readFileSync(file, 'utf8');
|
|
const profile = JSON.parse(data);
|
|
const first = findFirstFrameInNode(profile.head, func);
|
|
return { frame: first, roots: profile.head.children };
|
|
}
|
|
|
|
function verifyFrames(output, file, func) {
|
|
const { frame, roots } = findFirstFrame(file, func);
|
|
if (!frame) {
|
|
// Show native debug output and the profile for debugging.
|
|
console.log(output.stderr.toString());
|
|
console.log(roots);
|
|
}
|
|
assert.notDeepStrictEqual(frame, undefined);
|
|
}
|
|
|
|
const kHeapProfInterval = 128;
|
|
const TEST_ALLOCATION = kHeapProfInterval * 2;
|
|
|
|
const env = {
|
|
...process.env,
|
|
TEST_ALLOCATION,
|
|
NODE_DEBUG_NATIVE: 'INSPECTOR_PROFILER'
|
|
};
|
|
|
|
function getHeapProfiles(dir) {
|
|
const list = fs.readdirSync(dir);
|
|
return list
|
|
.filter((file) => file.endsWith('.heapprofile'))
|
|
.map((file) => path.join(dir, file));
|
|
}
|
|
|
|
// Test --diagnostic-dir changes the default for --cpu-prof
|
|
{
|
|
tmpdir.refresh();
|
|
const dir = path.join(tmpdir.path, 'prof');
|
|
const output = spawnSync(process.execPath, [
|
|
'--heap-prof',
|
|
'--diagnostic-dir',
|
|
dir,
|
|
'--heap-prof-interval',
|
|
kHeapProfInterval,
|
|
fixtures.path('workload', 'allocation.js'),
|
|
], {
|
|
cwd: tmpdir.path,
|
|
env
|
|
});
|
|
if (output.status !== 0) {
|
|
console.log(output.stderr.toString());
|
|
}
|
|
assert.strictEqual(output.status, 0);
|
|
assert(fs.existsSync(dir));
|
|
const profiles = getHeapProfiles(dir);
|
|
assert.strictEqual(profiles.length, 1);
|
|
verifyFrames(output, profiles[0], 'runAllocation');
|
|
}
|
|
|
|
// Test --heap-prof-dir overwrites --diagnostic-dir
|
|
{
|
|
tmpdir.refresh();
|
|
const dir = path.join(tmpdir.path, 'diag');
|
|
const dir2 = path.join(tmpdir.path, 'prof');
|
|
const output = spawnSync(process.execPath, [
|
|
'--heap-prof',
|
|
'--heap-prof-interval',
|
|
kHeapProfInterval,
|
|
'--diagnostic-dir',
|
|
dir,
|
|
'--heap-prof-dir',
|
|
dir2,
|
|
fixtures.path('workload', 'allocation.js'),
|
|
], {
|
|
cwd: tmpdir.path,
|
|
env
|
|
});
|
|
if (output.status !== 0) {
|
|
console.log(output.stderr.toString());
|
|
}
|
|
assert.strictEqual(output.status, 0);
|
|
assert(fs.existsSync(dir2));
|
|
const profiles = getHeapProfiles(dir2);
|
|
assert.strictEqual(profiles.length, 1);
|
|
verifyFrames(output, profiles[0], 'runAllocation');
|
|
}
|