mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
d1ef6aa2db
The old import assertions proposal has been
renamed to "import attributes" with the follwing major changes:
1. The keyword is now `with` instead of `assert`.
2. Unknown assertions cause an error rather than being ignored,
This commit updates the documentation to encourage folks to use the new
syntax, and add aliases for module customization hooks.
PR-URL: https://github.com/nodejs/node/pull/50140
Fixes: https://github.com/nodejs/node/issues/50134
Refs: 159c82c5e6
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
38 lines
1.4 KiB
JavaScript
38 lines
1.4 KiB
JavaScript
import { spawnPromisified } from '../common/index.mjs';
|
|
import assert from 'node:assert';
|
|
import { execPath } from 'node:process';
|
|
|
|
await Promise.all([
|
|
// Using importAssertions in the resolve hook should warn but still work.
|
|
`data:text/javascript,export ${encodeURIComponent(function resolve() {
|
|
return { shortCircuit: true, url: 'data:application/json,1', importAssertions: { type: 'json' } };
|
|
})}`,
|
|
// Setting importAssertions on the context object of the load hook should warn but still work.
|
|
`data:text/javascript,export ${encodeURIComponent(function load(u, c, n) {
|
|
c.importAssertions = { type: 'json' };
|
|
return n('data:application/json,1', c);
|
|
})}`,
|
|
// Creating a new context object with importAssertions in the load hook should warn but still work.
|
|
`data:text/javascript,export ${encodeURIComponent(function load(u, c, n) {
|
|
return n('data:application/json,1', { importAssertions: { type: 'json' } });
|
|
})}`,
|
|
].map(async (loaderURL) => {
|
|
const { stdout, stderr, code } = await spawnPromisified(execPath, [
|
|
'--input-type=module',
|
|
'--eval', `
|
|
import assert from 'node:assert';
|
|
import { register } from 'node:module';
|
|
|
|
register(${JSON.stringify(loaderURL)});
|
|
|
|
assert.deepStrictEqual(
|
|
{ ...await import('data:') },
|
|
{ default: 1 }
|
|
);`,
|
|
]);
|
|
|
|
assert.match(stderr, /Use `importAttributes` instead of `importAssertions`/);
|
|
assert.strictEqual(stdout, '');
|
|
assert.strictEqual(code, 0);
|
|
}));
|