c9c387fdac
Currently we use `{}` for the `lookup` function to find the relevant
resolver to the dns.resolve function. It is preferable to use an
object without a Object.prototype, currently for example you can do
something like:
```js
dns.resolve("google.com", "toString", console.log);
```
And get `[Object undefined]` logged and the callback would never be
called. This is unexpected and strange behavior in my opinion.
In addition, if someone adds a property to `Object.prototype` might
also create unexpected results.
This pull request fixes it, with it an appropriate error is thrown.
PR-URL: https://github.com/nodejs/node/pull/5843
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
||
|---|---|---|
| .. | ||
| abort | ||
| addons | ||
| cctest | ||
| debugger | ||
| disabled | ||
| fixtures | ||
| gc | ||
| internet | ||
| known_issues | ||
| message | ||
| parallel | ||
| pummel | ||
| sequential | ||
| testpy | ||
| timers | ||
| .eslintrc | ||
| common.js | ||
| README.md | ||
Tests
abort
Tests for when the --abort-on-uncaught-exception flag is used.
| Runs on CI |
|---|
| No |
addons
Tests for addon functionality.
| Runs on CI |
|---|
| Yes |
cctest
C++ test that is run as part of the build process.
| Runs on CI |
|---|
| Yes |
debugger
Tests for debugger functionality.
| Runs on CI |
|---|
| No |
disabled
Tests that have been disabled from running for various reasons.
| Runs on CI |
|---|
| No |
fixtures
Test fixtures used in various tests throughout the test suite.
gc
Tests for garbage collection related functionality.
| Runs on CI |
|---|
| No |
internet
Tests that make real outbound connections (mainly networking related modules). Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections.
| Runs on CI |
|---|
| No |
known_issues
Tests reproducing known issues within the system.
| Runs on CI |
|---|
| No |
message
Tests for messages that are output for various conditions (console.log,
error messages etc.)
| Runs on CI |
|---|
| Yes |
parallel
Various tests that are able to be run in parallel.
| Runs on CI |
|---|
| Yes |
pummel
Various tests for various modules / system functionality operating under load.
| Runs on CI |
|---|
| No |
sequential
Various tests that are run sequentially.
| Runs on CI |
|---|
| Yes |
testpy
Test configuration utility used by various test suites.
timers
Tests for timing utilities (setTimeout
and setInterval).
| Runs on CI |
|---|
| No |