mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
3838b579e4
Original commit message:
fix: EmbeddedTargetOs on IBM i with Python 3.9
For some context, Python 3.9 on IBM i returns "os400" for sys.platform
instead of "aix". We used to build with Python 3.6 which returned "aix"
as the platform
When attempting to build Node.js with python 3.9 on IBM i we run into a
build error.
Ref: https://github.com/nodejs/node/pull/48056
Ref: https://github.com/nodejs/node/pull/48056#issuecomment-1553719508
I'm not quite sure where target_os is being passed down to the function ToEmbeddedTargetOs.
It seems as though target_os is being generated from sys.platform or
similar call from python as we started running into this issue after
building with Python 3.9.
This PR supersedes initial changes proposed in:
https://chromium-review.googlesource.com/c/v8/v8/+/4259330
This PR contains the minimal changes to successfully build Node.js (builds v8 as an internal dep)
on IBM i with Python 3.9.
Change-Id: I32d43197bce994a72a0d85091e91f80eeea4482d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4846413
Commit-Queue: Jakob Linke <jgruber@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Jakob Linke <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#89981}
Refs:
|
||
|---|---|---|
| .. | ||
| acorn | ||
| ada | ||
| base64 | ||
| brotli | ||
| cares | ||
| cjs-module-lexer | ||
| corepack | ||
| googletest | ||
| histogram | ||
| icu-small | ||
| llhttp | ||
| minimatch | ||
| nghttp2 | ||
| ngtcp2 | ||
| npm | ||
| openssl | ||
| postject | ||
| simdutf | ||
| undici | ||
| uv | ||
| uvwasi | ||
| v8 | ||
| zlib | ||