Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity
0f7bdcc17f
node/test
History
Michael Dawson 0f7bdcc17f
test: fix test-tls-junk-closes-server 
Refs: https://github.com/nodejs/node/issues/53382

TLS spec seems to indicate there should should be a response
sent when TLS handshake fails. See
https://datatracker.ietf.org/doc/html/rfc8446#page-85

When compiled with OpenSSL32 we see the
the following response '15 03 03 00 02 02 16' which
decodes as a fatal (0x02) TLS error alert number 22 (0x16).
which corresponds to TLS1_AD_RECORD_OVERFLOW which matches
the error we see if NODE_DEBUG is turned on once you get
through the define aliases.

If there is a response from the server the test used to
hang because the end event will not be emitted until after
the response is consumed. This PR fixes the test so
it consumes the response.

Some earlier OpenSSL versions did not seem to send a response but
the error handling seems to have been re-written/improved
in OpenSSL32.

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/55089
Refs: https://github.com/nodejs/node/issues/52482
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-25 21:28:05 +00:00
..
abort
addons test: merge ongc and gcutil into gc.js 2024-08-29 08:49:52 +01:00
async-hooks lib: prefer optional chaining 2024-09-24 19:48:15 +00:00
benchmark
cctest path: fix bugs and inconsistencies 2024-09-14 14:56:31 +00:00
common test: fix assertSnapshot when path contains a quote 2024-09-25 19:42:12 +00:00
doctool
embedding test: fix embedding test for Windows 2024-08-27 21:30:50 +00:00
es-module test: fix some tests when path contains % 2024-09-25 17:25:33 +00:00
fixtures test_runner: fix mocking modules with quote in their URL 2024-09-25 17:34:58 +00:00
fuzzers
internet
js-native-api node-api: add support for UTF-8 and Latin-1 property keys 2024-09-13 13:01:52 -07:00
known_issues vm: return all own names and symbols in property enumerator interceptor 2024-08-30 11:22:58 +00:00
message cli: ensure --run has proper pwd 2024-09-18 12:18:40 +00:00
node-api test: merge ongc and gcutil into gc.js 2024-08-29 08:49:52 +01:00
overlapped-checker
parallel test: fix test-tls-junk-closes-server 2024-09-25 21:28:05 +00:00
pseudo-tty test: fix more tests that fail when path contains a space 2024-09-25 21:27:50 +00:00
pummel Revert "test: mark test-fs-watch-non-recursive flaky on Windows" 2024-09-25 13:18:52 +00:00
report
sequential test: do not assume process.execPath contains no spaces 2024-09-22 13:03:30 +00:00
testpy
tick-processor
tools
v8-updates
wasi
wasm-allocation
wpt test,crypto: update WebCryptoAPI WPT 2024-08-29 16:46:40 +00:00
eslint.config_partial.mjs
README.md
root.status

README.md

Node.js Core Tests

This directory contains code and data used to test the Node.js implementation.

For a detailed guide on how to write tests in this directory, see the guide on writing tests.

On how to run tests in this directory, see the contributing guide.

For the tests to run on Windows, be sure to clone Node.js source code with the autocrlf git config flag set to true.

Test Directories

Directory Runs on CI Purpose
abort Yes Tests that use --abort-on-uncaught-exception and other cases where we want to avoid generating a core file.
addons Yes Tests for addon functionality along with some tests that require an addon.
async-hooks Yes Tests for async_hooks functionality.
benchmark Yes Test minimal functionality of benchmarks.
cctest Yes C++ tests that are run as part of the build process.
code-cache No Tests for a Node.js binary compiled with V8 code cache.
common N/A Common modules shared among many tests.1
doctool Yes Tests for the documentation generator.
es-module Yes Test ESM module loading.
fixtures N/A Test fixtures used in various tests throughout the test suite.
internet No Tests that make real outbound network connections.2
js-native-api Yes Tests for Node.js-agnostic Node-API functionality.
known_issues Yes Tests reproducing known issues within the system.3
message Yes Tests for messages that are output for various conditions
node-api Yes Tests for Node.js-specific Node-API functionality.
parallel Yes Various tests that are able to be run in parallel.
pseudo-tty Yes Tests that require stdin/stdout/stderr to be a TTY.
pummel No Various tests for various modules / system functionality operating under load.
sequential Yes Various tests that must not run in parallel.
testpy N/A Test configuration utility used by various test suites.
tick-processor No Tests for the V8 tick processor integration.4
v8-updates No Tests for V8 performance integration.

  1. Documentation ↩︎

  2. Tests for networking related modules may also be present in other directories, but those tests do not make outbound connections. ↩︎

  3. All tests inside of this directory are expected to fail. If a test doesn't fail on certain platforms, those should be skipped via known_issues.status. ↩︎

  4. The tests are for the logic in lib/internal/v8_prof_processor.js and lib/internal/v8_prof_polyfill.js. The tests confirm that the profile processor packages the correct set of scripts from V8 and introduces the correct platform specific logic. ↩︎