mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
5e5af2947f
PR-URL: https://github.com/nodejs/node/pull/55318 Reviewed-By: Michaël Zasso <targos@protonmail.com>
225 lines
6.3 KiB
JavaScript
225 lines
6.3 KiB
JavaScript
/**
|
|
* @fileoverview We shouldn't use global built-in object for security and
|
|
* performance reason. This linter rule reports replaceable codes
|
|
* that can be replaced with primordials.
|
|
* @author Leko <leko.noor@gmail.com>
|
|
*/
|
|
'use strict';
|
|
|
|
//------------------------------------------------------------------------------
|
|
// Rule Definition
|
|
//------------------------------------------------------------------------------
|
|
|
|
function toPrimordialsName(obj, prop) {
|
|
return obj + toUcFirst(prop);
|
|
}
|
|
|
|
function toUcFirst(str) {
|
|
return str[0].toUpperCase() + str.slice(1);
|
|
}
|
|
|
|
function isTarget(map, varName) {
|
|
return map.has(varName);
|
|
}
|
|
|
|
function isIgnored(map, varName, propName) {
|
|
return map.get(varName)?.get(propName)?.ignored ?? false;
|
|
}
|
|
|
|
function getReportName({ name, parentName, into }) {
|
|
if (into) {
|
|
return toPrimordialsName(into, name);
|
|
}
|
|
if (parentName) {
|
|
return toPrimordialsName(parentName, name);
|
|
}
|
|
return name;
|
|
}
|
|
|
|
/**
|
|
* Get identifier of object spread assignment
|
|
*
|
|
* code: 'const { ownKeys } = Reflect;'
|
|
* argument: 'ownKeys'
|
|
* return: 'Reflect'
|
|
*/
|
|
function getDestructuringAssignmentParent(scope, node) {
|
|
const declaration = scope.set.get(node.name);
|
|
if (
|
|
!declaration ||
|
|
!declaration.defs ||
|
|
declaration.defs.length === 0 ||
|
|
declaration.defs[0].type !== 'Variable' ||
|
|
!declaration.defs[0].node.init
|
|
) {
|
|
return null;
|
|
}
|
|
return declaration.defs[0].node.init;
|
|
}
|
|
|
|
const parentSelectors = [
|
|
// We want to select identifiers that refer to other references, not the ones
|
|
// that create a new reference.
|
|
'ClassDeclaration',
|
|
'FunctionDeclaration',
|
|
'LabeledStatement',
|
|
'MemberExpression',
|
|
'MethodDefinition',
|
|
'SwitchCase',
|
|
'VariableDeclarator',
|
|
];
|
|
const identifierSelector = parentSelectors.map((selector) => `[type!=${selector}]`).join('') + '>Identifier';
|
|
|
|
module.exports = {
|
|
meta: {
|
|
messages: {
|
|
error: 'Use `const { {{name}} } = primordials;` instead of the global.',
|
|
errorPolyfill: 'Use `const { {{name}} } = require("internal/util");` instead of the primordial.',
|
|
},
|
|
schema: {
|
|
type: 'array',
|
|
items: [
|
|
{
|
|
type: 'object',
|
|
required: ['name'],
|
|
properties: {
|
|
name: { type: 'string' },
|
|
ignore: {
|
|
type: 'array',
|
|
items: { type: 'string' },
|
|
},
|
|
into: { type: 'string' },
|
|
polyfilled: {
|
|
type: 'array',
|
|
items: { type: 'string' },
|
|
},
|
|
},
|
|
additionalProperties: false,
|
|
},
|
|
],
|
|
},
|
|
},
|
|
create(context) {
|
|
const globalScope = context.sourceCode.scopeManager.globalScope;
|
|
|
|
const nameMap = new Map();
|
|
const renameMap = new Map();
|
|
const polyfilledSet = new Set();
|
|
|
|
for (const option of context.options) {
|
|
const names = option.ignore || [];
|
|
nameMap.set(
|
|
option.name,
|
|
new Map(names.map((name) => [name, { ignored: true }])),
|
|
);
|
|
if (option.into) {
|
|
renameMap.set(option.name, option.into);
|
|
}
|
|
if (option.polyfilled) {
|
|
for (const propertyName of option.polyfilled) {
|
|
polyfilledSet.add(`${option.name}${propertyName[0].toUpperCase()}${propertyName.slice(1)}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
let reported;
|
|
|
|
return {
|
|
Program() {
|
|
reported = new Set();
|
|
},
|
|
[identifierSelector](node) {
|
|
if (node.parent.type === 'Property' && node.parent.key === node) {
|
|
// If the identifier is the key for this property declaration, it
|
|
// can't be referring to a primordials member.
|
|
return;
|
|
}
|
|
if (reported.has(node.range[0])) {
|
|
return;
|
|
}
|
|
const name = node.name;
|
|
const parent = getDestructuringAssignmentParent(
|
|
context.sourceCode.getScope(node),
|
|
node,
|
|
);
|
|
const parentName = parent?.name;
|
|
if (!isTarget(nameMap, name) && (!isTarget(nameMap, parentName) || isIgnored(nameMap, parentName, name))) {
|
|
return;
|
|
}
|
|
|
|
const defs = globalScope.set.get(name)?.defs;
|
|
if (parentName && isTarget(nameMap, parentName)) {
|
|
if (defs?.[0].name.name !== 'primordials' &&
|
|
!reported.has(parent.range[0]) &&
|
|
parent.parent?.id?.type !== 'Identifier') {
|
|
reported.add(node.range[0]);
|
|
const into = renameMap.get(name);
|
|
context.report({
|
|
node,
|
|
messageId: 'error',
|
|
data: {
|
|
name: getReportName({ into, parentName, name }),
|
|
},
|
|
});
|
|
}
|
|
return;
|
|
}
|
|
if (defs.length === 0 || defs[0].node.init.name !== 'primordials') {
|
|
reported.add(node.range[0]);
|
|
const into = renameMap.get(name);
|
|
context.report({
|
|
node,
|
|
messageId: 'error',
|
|
data: {
|
|
name: getReportName({ into, parentName, name }),
|
|
},
|
|
});
|
|
}
|
|
},
|
|
MemberExpression(node) {
|
|
const obj = node.object.name;
|
|
const prop = node.property.name;
|
|
if (!prop || !isTarget(nameMap, obj) || isIgnored(nameMap, obj, prop)) {
|
|
return;
|
|
}
|
|
|
|
const variables =
|
|
context.sourceCode.scopeManager.getDeclaredVariables(node);
|
|
if (variables.length === 0) {
|
|
context.report({
|
|
node,
|
|
messageId: 'error',
|
|
data: {
|
|
name: toPrimordialsName(obj, prop),
|
|
},
|
|
});
|
|
}
|
|
},
|
|
VariableDeclarator(node) {
|
|
const name = node.init?.name;
|
|
if (name === 'primordials' && node.id.type === 'ObjectPattern') {
|
|
const name = node.id.properties.find(({ key }) => polyfilledSet.has(key.name))?.key.name;
|
|
if (name) {
|
|
context.report({
|
|
node,
|
|
messageId: 'errorPolyfill',
|
|
data: { name },
|
|
});
|
|
return;
|
|
}
|
|
}
|
|
if (name !== undefined && isTarget(nameMap, name) &&
|
|
node.id.type === 'Identifier' &&
|
|
!globalScope.set.get(name)?.defs.length) {
|
|
reported.add(node.init.range[0]);
|
|
context.report({
|
|
node,
|
|
messageId: 'error',
|
|
data: { name },
|
|
});
|
|
}
|
|
},
|
|
};
|
|
},
|
|
};
|