node/test-stderr-stdout-handle-sigwinch.out at main - node - Alpaca Bi's Private Git Pepository

Nodejs/node

mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00

Joyee Cheung 333783643e

console: lazy load process.stderr and process.stdout

This patch:

- Refactors the Console constructor: moves the property binding code
  into and the writable streams binding code into two methods defined
  on the Console.prototype with symbols.
- Refactors the global console creation: we only need to share the
  property binding code from the Console constructor. To bind the
  streams we can lazy load `process.stdio` and `process.stderr`
  so that we don't create these streams when they are not used.
  This significantly reduces the number of modules loaded during
  bootstrap. Also, by calling the refactored-out method directly
  we can skip the unnecessary typechecks when creating the global
  console and there is no need to create a temporary Console
  anymore.
- Refactors the error handler creation and the `write` method:
  use a `kUseStdout` symbol to tell the internals which stream
  should be loaded from the console instance. Also put the
  `write` method on the Console prototype so it just loads
  other properties directly off the console instance which simplifies
  the call sites.

Also leaves a few TODOs for further refactoring of the console
bootstrap.

PR-URL: https://github.com/nodejs/node/pull/24534
Reviewed-By: Gus Caplan <me@gus.host>

2018-11-29 01:52:54 +08:00

3 lines

56 B

Plaintext

Raw Permalink Blame History

	`calling stderr._refreshSize`
	`calling stdout._refreshSize`