mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
58 lines
1.9 KiB
JavaScript
58 lines
1.9 KiB
JavaScript
'use strict';
|
|
|
|
// Tests below are not from WPT.
|
|
|
|
const common = require('../common');
|
|
|
|
if (!common.hasIntl)
|
|
common.skip('missing Intl');
|
|
|
|
const assert = require('assert');
|
|
const { domainToASCII, domainToUnicode } = require('url');
|
|
|
|
const tests = require('../fixtures/url-idna');
|
|
const fixtures = require('../common/fixtures');
|
|
const wptToASCIITests = require(
|
|
fixtures.path('wpt', 'url', 'resources', 'toascii.json')
|
|
);
|
|
|
|
{
|
|
const expectedError = { code: 'ERR_MISSING_ARGS', name: 'TypeError' };
|
|
assert.throws(() => domainToASCII(), expectedError);
|
|
assert.throws(() => domainToUnicode(), expectedError);
|
|
assert.strictEqual(domainToASCII(undefined), 'undefined');
|
|
assert.strictEqual(domainToUnicode(undefined), 'undefined');
|
|
}
|
|
|
|
{
|
|
for (const [i, { ascii, unicode }] of tests.entries()) {
|
|
assert.strictEqual(ascii, domainToASCII(unicode),
|
|
`domainToASCII(${i + 1})`);
|
|
assert.strictEqual(unicode, domainToUnicode(ascii),
|
|
`domainToUnicode(${i + 1})`);
|
|
assert.strictEqual(ascii, domainToASCII(domainToUnicode(ascii)),
|
|
`domainToASCII(domainToUnicode(${i + 1}))`);
|
|
assert.strictEqual(unicode, domainToUnicode(domainToASCII(unicode)),
|
|
`domainToUnicode(domainToASCII(${i + 1}))`);
|
|
}
|
|
}
|
|
|
|
{
|
|
for (const [i, test] of wptToASCIITests.entries()) {
|
|
if (typeof test === 'string')
|
|
continue; // skip comments
|
|
const { comment, input, output } = test;
|
|
let caseComment = `Case ${i + 1}`;
|
|
if (comment)
|
|
caseComment += ` (${comment})`;
|
|
if (output === null) {
|
|
assert.strictEqual(domainToASCII(input), '', caseComment);
|
|
assert.strictEqual(domainToUnicode(input), '', caseComment);
|
|
} else {
|
|
assert.strictEqual(domainToASCII(input), output, caseComment);
|
|
const roundtripped = domainToASCII(domainToUnicode(input));
|
|
assert.strictEqual(roundtripped, output, caseComment);
|
|
}
|
|
}
|
|
}
|