mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
f663b31cc2
Ensure the callback is always invoked before emitting the error in both sync and async case. PR-URL: https://github.com/nodejs/node/pull/29293 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
59 lines
1.2 KiB
JavaScript
59 lines
1.2 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const { Writable } = require('stream');
|
|
const assert = require('assert');
|
|
|
|
// Ensure callback is always invoked before
|
|
// error is emitted. Regardless if error was
|
|
// sync or async.
|
|
|
|
{
|
|
let callbackCalled = false;
|
|
// Sync Error
|
|
const writable = new Writable({
|
|
write: common.mustCall((buf, enc, cb) => {
|
|
cb(new Error());
|
|
})
|
|
});
|
|
writable.on('error', common.mustCall(() => {
|
|
assert.strictEqual(callbackCalled, true);
|
|
}));
|
|
writable.write('hi', common.mustCall(() => {
|
|
callbackCalled = true;
|
|
}));
|
|
}
|
|
|
|
{
|
|
let callbackCalled = false;
|
|
// Async Error
|
|
const writable = new Writable({
|
|
write: common.mustCall((buf, enc, cb) => {
|
|
process.nextTick(cb, new Error());
|
|
})
|
|
});
|
|
writable.on('error', common.mustCall(() => {
|
|
assert.strictEqual(callbackCalled, true);
|
|
}));
|
|
writable.write('hi', common.mustCall(() => {
|
|
callbackCalled = true;
|
|
}));
|
|
}
|
|
|
|
{
|
|
// Sync Error
|
|
const writable = new Writable({
|
|
write: common.mustCall((buf, enc, cb) => {
|
|
cb(new Error());
|
|
})
|
|
});
|
|
|
|
writable.on('error', common.mustCall());
|
|
|
|
let cnt = 0;
|
|
// Ensure we don't live lock on sync error
|
|
while (writable.write('a'))
|
|
cnt++;
|
|
|
|
assert.strictEqual(cnt, 0);
|
|
}
|