mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
1abff07392
This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: https://github.com/nodejs/node/pull/52037 Refs: https://github.com/nodejs/node/pull/46608 Refs: https://github.com/nodejs/node/pull/50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
74 lines
2.1 KiB
JavaScript
74 lines
2.1 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const { Transform, Readable, Writable, getDefaultHighWaterMark } = require('stream');
|
|
|
|
const DEFAULT = getDefaultHighWaterMark();
|
|
|
|
function testTransform(expectedReadableHwm, expectedWritableHwm, options) {
|
|
const t = new Transform(options);
|
|
assert.strictEqual(t._readableState.highWaterMark, expectedReadableHwm);
|
|
assert.strictEqual(t._writableState.highWaterMark, expectedWritableHwm);
|
|
}
|
|
|
|
// Test overriding defaultHwm
|
|
testTransform(666, DEFAULT, { readableHighWaterMark: 666 });
|
|
testTransform(DEFAULT, 777, { writableHighWaterMark: 777 });
|
|
testTransform(666, 777, {
|
|
readableHighWaterMark: 666,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
|
|
// Test highWaterMark overriding
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
readableHighWaterMark: 666,
|
|
});
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
testTransform(555, 555, {
|
|
highWaterMark: 555,
|
|
readableHighWaterMark: 666,
|
|
writableHighWaterMark: 777,
|
|
});
|
|
|
|
// Test undefined, null
|
|
[undefined, null].forEach((v) => {
|
|
testTransform(DEFAULT, DEFAULT, { readableHighWaterMark: v });
|
|
testTransform(DEFAULT, DEFAULT, { writableHighWaterMark: v });
|
|
testTransform(666, DEFAULT, { highWaterMark: v, readableHighWaterMark: 666 });
|
|
testTransform(DEFAULT, 777, { highWaterMark: v, writableHighWaterMark: 777 });
|
|
});
|
|
|
|
// test NaN
|
|
{
|
|
assert.throws(() => {
|
|
new Transform({ readableHighWaterMark: NaN });
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
message: "The property 'options.readableHighWaterMark' is invalid. " +
|
|
'Received NaN'
|
|
});
|
|
|
|
assert.throws(() => {
|
|
new Transform({ writableHighWaterMark: NaN });
|
|
}, {
|
|
name: 'TypeError',
|
|
code: 'ERR_INVALID_ARG_VALUE',
|
|
message: "The property 'options.writableHighWaterMark' is invalid. " +
|
|
'Received NaN'
|
|
});
|
|
}
|
|
|
|
// Test non Duplex streams ignore the options
|
|
{
|
|
const r = new Readable({ readableHighWaterMark: 666 });
|
|
assert.strictEqual(r._readableState.highWaterMark, DEFAULT);
|
|
const w = new Writable({ writableHighWaterMark: 777 });
|
|
assert.strictEqual(w._writableState.highWaterMark, DEFAULT);
|
|
}
|