mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
20c3ac2556
`readable.resume()` calls `.read(0)`, which in turn previously set `needReadable = true`, and so a subsequent `.read()` call would call `_read()` even though enough data was already available. This can lead to elevated memory usage, because calling `_read()` when enough data is in the readable buffer means that backpressure is not being honoured. Fixes: https://github.com/nodejs/node/issues/26957 PR-URL: https://github.com/nodejs/node/pull/26965 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
22 lines
677 B
JavaScript
22 lines
677 B
JavaScript
'use strict';
|
||
const common = require('../common');
|
||
const { Readable } = require('stream');
|
||
|
||
// readable.resume() should not lead to a ._read() call being scheduled
|
||
// when we exceed the high water mark already.
|
||
|
||
const readable = new Readable({
|
||
read: common.mustNotCall(),
|
||
highWaterMark: 100
|
||
});
|
||
|
||
// Fill up the internal buffer so that we definitely exceed the HWM:
|
||
for (let i = 0; i < 10; i++)
|
||
readable.push('a'.repeat(200));
|
||
|
||
// Call resume, and pause after one chunk.
|
||
// The .pause() is just so that we don’t empty the buffer fully, which would
|
||
// be a valid reason to call ._read().
|
||
readable.resume();
|
||
readable.once('data', common.mustCall(() => readable.pause()));
|