mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
dd52c05046
Comparing any value to any non-RegExp literal or undefined using
strictEqual (or notStrictEqual) passes if and only if deepStrictEqual
(or notDeepStrictEqual, respectively) passes.
Unnecessarily using deep comparisons adds confusion.
This patch adds an ESLint rule that forbids the use of deepStrictEqual
and notDeepStrictEqual when the expected value (i.e., the second
argument) is a non-RegExp literal or undefined.
For reference, an ESTree literal is defined as follows.
extend interface Literal <: Expression {
type: "Literal";
value: string | boolean | null | number | RegExp | bigint;
}
The value `undefined` is an `Identifier` with `name: 'undefined'`.
PR-URL: https://github.com/nodejs/node/pull/40634
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
42 lines
1.3 KiB
JavaScript
42 lines
1.3 KiB
JavaScript
'use strict';
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const qs = require('querystring');
|
|
|
|
assert.strictEqual(qs.escape(5), '5');
|
|
assert.strictEqual(qs.escape('test'), 'test');
|
|
assert.strictEqual(qs.escape({}), '%5Bobject%20Object%5D');
|
|
assert.strictEqual(qs.escape([5, 10]), '5%2C10');
|
|
assert.strictEqual(qs.escape('Ŋōđĕ'), '%C5%8A%C5%8D%C4%91%C4%95');
|
|
assert.strictEqual(qs.escape('testŊōđĕ'), 'test%C5%8A%C5%8D%C4%91%C4%95');
|
|
assert.strictEqual(qs.escape(`${String.fromCharCode(0xD800 + 1)}test`),
|
|
'%F0%90%91%B4est');
|
|
|
|
assert.throws(
|
|
() => qs.escape(String.fromCharCode(0xD800 + 1)),
|
|
{
|
|
code: 'ERR_INVALID_URI',
|
|
name: 'URIError',
|
|
message: 'URI malformed'
|
|
}
|
|
);
|
|
|
|
// Using toString for objects
|
|
assert.strictEqual(
|
|
qs.escape({ test: 5, toString: () => 'test', valueOf: () => 10 }),
|
|
'test'
|
|
);
|
|
|
|
// `toString` is not callable, must throw an error.
|
|
// Error message will vary between different JavaScript engines, so only check
|
|
// that it is a `TypeError`.
|
|
assert.throws(() => qs.escape({ toString: 5 }), TypeError);
|
|
|
|
// Should use valueOf instead of non-callable toString.
|
|
assert.strictEqual(qs.escape({ toString: 5, valueOf: () => 'test' }), 'test');
|
|
|
|
// Error message will vary between different JavaScript engines, so only check
|
|
// that it is a `TypeError`.
|
|
assert.throws(() => qs.escape(Symbol('test')), TypeError);
|