mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
37 lines
948 B
JavaScript
37 lines
948 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const http = require('http');
|
|
const stream = require('stream');
|
|
|
|
// Verify that when piping a stream to an `OutgoingMessage` (or a type that
|
|
// inherits from `OutgoingMessage`), if data is emitted after the
|
|
// `OutgoingMessage` was closed - a `write after end` error is raised
|
|
|
|
class MyStream extends stream {}
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
const myStream = new MyStream();
|
|
myStream.pipe(res);
|
|
|
|
process.nextTick(common.mustCall(() => {
|
|
res.end();
|
|
myStream.emit('data', 'some data');
|
|
res.on('error', common.expectsError({
|
|
code: 'ERR_STREAM_WRITE_AFTER_END',
|
|
name: 'Error'
|
|
}));
|
|
|
|
process.nextTick(common.mustCall(() => server.close()));
|
|
}));
|
|
}));
|
|
|
|
server.listen(0);
|
|
|
|
server.on('listening', common.mustCall(function() {
|
|
http.request({
|
|
port: server.address().port,
|
|
method: 'GET',
|
|
path: '/'
|
|
}).end();
|
|
}));
|