mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
0161ad0baf
`NodeRuntime.waitingForDebugger` is a new Inspector Protocol event that
will fire when the process being inspected is waiting for the debugger
(for example, when `inspector.waitForDebugger()` is called). This allows
inspecting processes to know when the inspected process is waiting for a
`Runtime.runIfWaitingForDebugger` message to resume execution. It allows
tooling to resume execution of the inspected process as soon as it deems
necessary, without having to guess if the inspected process is waiting
or not, making the workflow more deterministic. With a more
deterministic workflow, it is possible to update Node.js core tests to
avoid race conditions that can cause flakiness. Therefore, tests were
also changed as following:
* Remove no-op Runtime.runIfWaitingForDebugger from tests that don't
need it
* Use NodeRuntime.waitingForDebugger in all tests that need
Runtime.runIfWaitingForDebugger, to ensure order of operations is
predictable and correct
* Simplify test-inspector-multisession-ws
There might be value in adding `NodeWorker.waitingForDebugger` in a
future patch, but as of right now, no Node.js core inspector tests using
worker threads are not failing due to race conditions.
Fixes: https://github.com/nodejs/node/issues/34730
PR-URL: https://github.com/nodejs/node/pull/51560
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
48 lines
1.8 KiB
JavaScript
48 lines
1.8 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const assert = require('assert');
|
|
const { NodeInstance } = require('../common/inspector-helper.js');
|
|
|
|
function mainContextDestroyed(notification) {
|
|
return notification.method === 'Runtime.executionContextDestroyed' &&
|
|
notification.params.executionContextId === 1;
|
|
}
|
|
|
|
async function runTest() {
|
|
const child = new NodeInstance(['--inspect-brk=0', '-e', 'process.exit(55)']);
|
|
const session = await child.connectInspectorSession();
|
|
const oldStyleSession = await child.connectInspectorSession();
|
|
await oldStyleSession.send([
|
|
{ method: 'Runtime.enable' }]);
|
|
await session.send({ method: 'NodeRuntime.enable' });
|
|
await session.waitForNotification('NodeRuntime.waitingForDebugger');
|
|
await session.send([
|
|
{ method: 'Runtime.enable' },
|
|
{ method: 'NodeRuntime.notifyWhenWaitingForDisconnect',
|
|
params: { enabled: true } },
|
|
{ method: 'Runtime.runIfWaitingForDebugger' }]);
|
|
await session.send({ method: 'NodeRuntime.disable' });
|
|
await session.waitForNotification((notification) => {
|
|
return notification.method === 'NodeRuntime.waitingForDisconnect';
|
|
});
|
|
const receivedExecutionContextDestroyed =
|
|
session.unprocessedNotifications().some(mainContextDestroyed);
|
|
if (receivedExecutionContextDestroyed) {
|
|
assert.fail('When NodeRuntime enabled, ' +
|
|
'Runtime.executionContextDestroyed should not be sent');
|
|
}
|
|
const { result: { value } } = await session.send({
|
|
method: 'Runtime.evaluate', params: { expression: '42' }
|
|
});
|
|
assert.strictEqual(value, 42);
|
|
await session.disconnect();
|
|
await oldStyleSession.waitForNotification(mainContextDestroyed);
|
|
await oldStyleSession.disconnect();
|
|
assert.strictEqual((await child.expectShutdown()).exitCode, 55);
|
|
}
|
|
|
|
runTest().then(common.mustCall());
|