mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
330f25ef82
Make changes so that tests will pass when the comma-dangle settings applied to the rest of the code base are also applied to tests. PR-URL: https://github.com/nodejs/node/pull/37930 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
99 lines
2.4 KiB
JavaScript
99 lines
2.4 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const http2 = require('http2');
|
|
const { internalBinding } = require('internal/test/binding');
|
|
const {
|
|
constants,
|
|
Http2Stream,
|
|
nghttp2ErrorString
|
|
} = internalBinding('http2');
|
|
const { NghttpError } = require('internal/http2/util');
|
|
|
|
// Tests error handling within pushStream
|
|
// - NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE (should emit session error)
|
|
// - NGHTTP2_ERR_STREAM_CLOSED (should emit stream error)
|
|
// - every other NGHTTP2 error from binding (should emit stream error)
|
|
|
|
const specificTestKeys = [
|
|
'NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE',
|
|
'NGHTTP2_ERR_STREAM_CLOSED',
|
|
];
|
|
|
|
const specificTests = [
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_STREAM_ID_NOT_AVAILABLE,
|
|
error: {
|
|
code: 'ERR_HTTP2_OUT_OF_STREAMS',
|
|
name: 'Error',
|
|
message: 'No stream ID is available because ' +
|
|
'maximum stream ID has been reached'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
{
|
|
ngError: constants.NGHTTP2_ERR_STREAM_CLOSED,
|
|
error: {
|
|
code: 'ERR_HTTP2_INVALID_STREAM',
|
|
name: 'Error'
|
|
},
|
|
type: 'stream'
|
|
},
|
|
];
|
|
|
|
const genericTests = Object.getOwnPropertyNames(constants)
|
|
.filter((key) => (
|
|
key.indexOf('NGHTTP2_ERR') === 0 && specificTestKeys.indexOf(key) < 0
|
|
))
|
|
.map((key) => ({
|
|
ngError: constants[key],
|
|
error: {
|
|
code: 'ERR_HTTP2_ERROR',
|
|
constructor: NghttpError,
|
|
name: 'Error',
|
|
message: nghttp2ErrorString(constants[key])
|
|
},
|
|
type: 'stream'
|
|
}));
|
|
|
|
|
|
const tests = specificTests.concat(genericTests);
|
|
|
|
let currentError;
|
|
|
|
// Mock submitPushPromise because we only care about testing error handling
|
|
Http2Stream.prototype.pushPromise = () => currentError.ngError;
|
|
|
|
const server = http2.createServer();
|
|
server.on('stream', common.mustCall((stream, headers) => {
|
|
stream.pushStream({}, common.expectsError(currentError.error));
|
|
stream.respond();
|
|
stream.end();
|
|
}, tests.length));
|
|
|
|
server.listen(0, common.mustCall(() => runTest(tests.shift())));
|
|
|
|
function runTest(test) {
|
|
const url = `http://localhost:${server.address().port}`;
|
|
|
|
const client = http2.connect(url);
|
|
const req = client.request();
|
|
|
|
currentError = test;
|
|
req.resume();
|
|
req.end();
|
|
|
|
req.on('close', common.mustCall(() => {
|
|
client.close();
|
|
|
|
if (!tests.length) {
|
|
server.close();
|
|
} else {
|
|
runTest(tests.shift());
|
|
}
|
|
}));
|
|
}
|