mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
18a1796e3c
The ability to pause input processing was added in8a4a193but introduced a session memory accounting mismatch leading to potential NGHTTP2_ENHANCE_YOUR_CALM errors. After pausing (f36331c1bf/src/node_http2.cc (L871)), the early return on line 873 skips the DecrementCurrentSessionMemory(stream_buf_.len) call below (line 878). When we later finished processing the input chunk (f36331c1bf/src/node_http2.cc (L1858)), we were calling DecrementCurrentSessionMemory(stream_buf_offset_) [line 1875] which was a no-op since we just set stream_buf_offset_ to 0 [line 1873]. The correct amount to decrement by is still stream_buf_.len, since that's the amount we skipped previously (line 878). Fixes: https://github.com/nodejs/node/issues/29223 Refs:164ac5b241PR-URL: https://github.com/nodejs/node/pull/30684 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
56 lines
1.6 KiB
JavaScript
56 lines
1.6 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const fixtures = require('../common/fixtures');
|
|
const http2 = require('http2');
|
|
|
|
// Regression test for https://github.com/nodejs/node/issues/29223.
|
|
// There was a "leak" in the accounting of session memory leading
|
|
// to streams eventually failing with NGHTTP2_ENHANCE_YOUR_CALM.
|
|
|
|
const server = http2.createSecureServer({
|
|
key: fixtures.readKey('agent2-key.pem'),
|
|
cert: fixtures.readKey('agent2-cert.pem'),
|
|
});
|
|
|
|
// Simple server that sends 200k and closes the stream.
|
|
const data200k = 'a'.repeat(200 * 1024);
|
|
server.on('stream', (stream) => {
|
|
stream.write(data200k);
|
|
stream.end();
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`https://localhost:${server.address().port}`, {
|
|
ca: fixtures.readKey('agent2-cert.pem'),
|
|
servername: 'agent2',
|
|
|
|
// Set maxSessionMemory to 1MB so the leak causes errors faster.
|
|
maxSessionMemory: 1
|
|
});
|
|
|
|
// Repeatedly create a new stream and read the incoming data. Even though we
|
|
// only have one stream active at a time, prior to the fix for #29223,
|
|
// session memory would steadily increase and we'd eventually hit the 1MB
|
|
// maxSessionMemory limit and get NGHTTP2_ENHANCE_YOUR_CALM errors trying to
|
|
// create new streams.
|
|
let streamsLeft = 50;
|
|
function newStream() {
|
|
const stream = client.request({ ':path': '/' });
|
|
|
|
stream.on('data', () => { });
|
|
|
|
stream.on('close', () => {
|
|
if (streamsLeft-- > 0) {
|
|
newStream();
|
|
} else {
|
|
client.destroy();
|
|
server.close();
|
|
}
|
|
});
|
|
}
|
|
|
|
newStream();
|
|
}));
|