mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
46c3f4da05
Change ServerResponse.assignSocket to not throw an internal error, but an error with its own code. Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: https://github.com/nodejs/node/pull/47723 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
41 lines
901 B
JavaScript
41 lines
901 B
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const { ServerResponse } = require('http');
|
|
const { Writable } = require('stream');
|
|
const assert = require('assert');
|
|
|
|
// Check that ServerResponse can be used without a proper Socket
|
|
// Refs: https://github.com/nodejs/node/issues/14386
|
|
// Refs: https://github.com/nodejs/node/issues/14381
|
|
|
|
const res = new ServerResponse({
|
|
method: 'GET',
|
|
httpVersionMajor: 1,
|
|
httpVersionMinor: 1
|
|
});
|
|
|
|
let firstChunk = true;
|
|
|
|
const ws = new Writable({
|
|
write: common.mustCall((chunk, encoding, callback) => {
|
|
if (firstChunk) {
|
|
assert(chunk.toString().endsWith('hello world'));
|
|
firstChunk = false;
|
|
} else {
|
|
assert.strictEqual(chunk.length, 0);
|
|
}
|
|
setImmediate(callback);
|
|
}, 2)
|
|
});
|
|
|
|
res.assignSocket(ws);
|
|
|
|
assert.throws(function() {
|
|
res.assignSocket(ws);
|
|
}, {
|
|
code: 'ERR_HTTP_SOCKET_ASSIGNED'
|
|
});
|
|
|
|
res.end('hello world');
|