mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
34 lines
983 B
JavaScript
34 lines
983 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
// This test ensures that a Trailer header is set only when a chunked transfer
|
|
// encoding is used.
|
|
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const server = http.createServer(common.mustCall(function(req, res) {
|
|
res.setHeader('Trailer', 'baz');
|
|
const trailerInvalidErr = {
|
|
code: 'ERR_HTTP_TRAILER_INVALID',
|
|
message: 'Trailers are invalid with this transfer encoding',
|
|
name: 'Error'
|
|
};
|
|
assert.throws(() => res.writeHead(200, { 'Content-Length': '2' }),
|
|
trailerInvalidErr);
|
|
res.removeHeader('Trailer');
|
|
res.end('ok');
|
|
}));
|
|
server.listen(0, common.mustCall(() => {
|
|
http.get({ port: server.address().port }, common.mustCall((res) => {
|
|
assert.strictEqual(res.statusCode, 200);
|
|
let buf = '';
|
|
res.on('data', (chunk) => {
|
|
buf += chunk;
|
|
}).on('end', common.mustCall(() => {
|
|
assert.strictEqual(buf, 'ok');
|
|
}));
|
|
server.close();
|
|
}));
|
|
}));
|