node/test/parallel/test-http-head-throw-on-response-body-write.js
Gerrard Lindsay 5ec0f39a7a
http: prevent writing to the body when not allowed by HTTP spec
PR-URL: https://github.com/nodejs/node/pull/47732
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2023-05-13 17:09:26 +00:00

103 lines
2.9 KiB
JavaScript

// Copyright Joyent, Inc. and other Node contributors.
//
// Permission is hereby granted, free of charge, to any person obtaining a
// copy of this software and associated documentation files (the
// "Software"), to deal in the Software without restriction, including
// without limitation the rights to use, copy, modify, merge, publish,
// distribute, sublicense, and/or sell copies of the Software, and to permit
// persons to whom the Software is furnished to do so, subject to the
// following conditions:
//
// The above copyright notice and this permission notice shall be included
// in all copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
{
const server = http.createServer((req, res) => {
res.writeHead(200);
res.end('this is content');
});
server.listen(0);
server.on('listening', common.mustCall(function() {
const req = http.request({
port: this.address().port,
method: 'HEAD',
path: '/'
}, common.mustCall((res) => {
res.resume();
res.on('end', common.mustCall(function() {
server.close();
}));
}));
req.end();
}));
}
{
const server = http.createServer({
rejectNonStandardBodyWrites: true,
}, (req, res) => {
res.writeHead(204);
assert.throws(() => {
res.write('this is content');
}, {
code: 'ERR_HTTP_BODY_NOT_ALLOWED',
name: 'Error',
message: 'Adding content for this request method or response status is not allowed.'
});
res.end();
});
server.listen(0);
server.on('listening', common.mustCall(function() {
const req = http.request({
port: this.address().port,
method: 'GET',
path: '/'
}, common.mustCall((res) => {
res.resume();
res.on('end', common.mustCall(function() {
server.close();
}));
}));
req.end();
}));
}
{
const server = http.createServer({
rejectNonStandardBodyWrites: false,
}, (req, res) => {
res.writeHead(200);
res.end('this is content');
});
server.listen(0);
server.on('listening', common.mustCall(function() {
const req = http.request({
port: this.address().port,
method: 'HEAD',
path: '/'
}, common.mustCall((res) => {
res.resume();
res.on('end', common.mustCall(function() {
server.close();
}));
}));
req.end();
}));
}