node/test/parallel/test-http-client-timeout-option.js
Robert Nagy b04e88439a http: don't destroy completed request
Calling destroy() on a completed ClientRequest, i.e.
once 'close' will be emitted should be a noop. Also
before emitting 'close' destroyed === true.

Fixes: https://github.com/nodejs/node/issues/32851

PR-URL: https://github.com/nodejs/node/pull/33120
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2020-05-11 18:02:32 +02:00

41 lines
979 B
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const http = require('http');
assert.throws(() => {
http.request({ timeout: null });
}, /The "timeout" argument must be of type number/);
const options = {
method: 'GET',
port: undefined,
host: '127.0.0.1',
path: '/',
timeout: 1
};
const server = http.createServer();
server.listen(0, options.host, function() {
options.port = this.address().port;
const req = http.request(options);
req.on('error', function() {
// This space is intentionally left blank
});
req.on('close', common.mustCall(() => {
assert.strictEqual(req.destroyed, true);
server.close();
}));
let timeout_events = 0;
req.on('timeout', common.mustCall(() => timeout_events += 1));
setTimeout(function() {
req.destroy();
assert.strictEqual(timeout_events, 1);
}, common.platformTimeout(100));
setTimeout(function() {
req.end();
}, common.platformTimeout(10));
});