mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
70 lines
1.4 KiB
JavaScript
70 lines
1.4 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const http = require('http');
|
|
|
|
const baseOptions = {
|
|
method: 'GET',
|
|
port: undefined,
|
|
host: common.localhostIPv4,
|
|
};
|
|
|
|
const failingAgentOptions = [
|
|
true,
|
|
'agent',
|
|
{},
|
|
1,
|
|
() => null,
|
|
Symbol(),
|
|
];
|
|
|
|
const acceptableAgentOptions = [
|
|
false,
|
|
undefined,
|
|
null,
|
|
new http.Agent(),
|
|
];
|
|
|
|
const server = http.createServer((req, res) => {
|
|
res.end('hello');
|
|
});
|
|
|
|
let numberOfResponses = 0;
|
|
|
|
function createRequest(agent) {
|
|
const options = Object.assign(baseOptions, { agent });
|
|
const request = http.request(options);
|
|
request.end();
|
|
request.on('response', common.mustCall(() => {
|
|
numberOfResponses++;
|
|
if (numberOfResponses === acceptableAgentOptions.length) {
|
|
server.close();
|
|
}
|
|
}));
|
|
}
|
|
|
|
server.listen(0, baseOptions.host, common.mustCall(function() {
|
|
baseOptions.port = this.address().port;
|
|
|
|
failingAgentOptions.forEach((agent) => {
|
|
assert.throws(
|
|
() => createRequest(agent),
|
|
{
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "options.agent" property must be one of Agent-like ' +
|
|
'Object, undefined, or false.' +
|
|
common.invalidArgTypeHelper(agent)
|
|
}
|
|
);
|
|
});
|
|
|
|
acceptableAgentOptions.forEach((agent) => {
|
|
createRequest(agent);
|
|
});
|
|
}));
|
|
|
|
process.on('exit', () => {
|
|
assert.strictEqual(numberOfResponses, acceptableAgentOptions.length);
|
|
});
|