node/test/parallel/test-fs-rename-type-check.js
Ruben Bridgewater ac2fc0dd5f
errors: improve ERR_INVALID_ARG_TYPE
ERR_INVALID_ARG_TYPE is the most common error used throughout the
code base. This improves the error message by providing more details
to the user and by indicating more precisely which values are allowed
ones and which ones are not.

It adds the actual input to the error message in case it's a primitive.
If it's a class instance, it'll print the class name instead of
"object" and "falsy" or similar entries are not named "type" anymore.

PR-URL: https://github.com/nodejs/node/pull/29675
Reviewed-By: Rich Trott <rtrott@gmail.com>
2019-12-20 03:10:13 +01:00

43 lines
1.1 KiB
JavaScript

'use strict';
const common = require('../common');
const assert = require('assert');
const fs = require('fs');
[false, 1, [], {}, null, undefined].forEach((input) => {
const type = 'of type string or an instance of Buffer or URL.' +
common.invalidArgTypeHelper(input);
assert.throws(
() => fs.rename(input, 'does-not-exist', common.mustNotCall()),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "oldPath" argument must be ${type}`
}
);
assert.throws(
() => fs.rename('does-not-exist', input, common.mustNotCall()),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "newPath" argument must be ${type}`
}
);
assert.throws(
() => fs.renameSync(input, 'does-not-exist'),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "oldPath" argument must be ${type}`
}
);
assert.throws(
() => fs.renameSync('does-not-exist', input),
{
code: 'ERR_INVALID_ARG_TYPE',
name: 'TypeError',
message: `The "newPath" argument must be ${type}`
}
);
});