mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
32 lines
728 B
JavaScript
32 lines
728 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const fixture = fixtures.path('empty.js');
|
|
const child = cp.fork(fixture);
|
|
|
|
child.on('close', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
|
|
const testError = common.expectsError({
|
|
name: 'Error',
|
|
message: 'Channel closed',
|
|
code: 'ERR_IPC_CHANNEL_CLOSED'
|
|
}, 2);
|
|
|
|
child.on('error', testError);
|
|
|
|
{
|
|
const result = child.send('ping');
|
|
assert.strictEqual(result, false);
|
|
}
|
|
|
|
{
|
|
const result = child.send('pong', testError);
|
|
assert.strictEqual(result, false);
|
|
}
|
|
}));
|