mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
55 lines
1.3 KiB
JavaScript
55 lines
1.3 KiB
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
const net = require('net');
|
|
|
|
if (process.argv[2] === 'child') {
|
|
process.stdout.write('this should be ignored');
|
|
process.stderr.write('this should not be ignored');
|
|
|
|
const pipe = new net.Socket({ fd: 4 });
|
|
|
|
process.on('disconnect', () => {
|
|
pipe.unref();
|
|
});
|
|
|
|
pipe.setEncoding('utf8');
|
|
pipe.on('data', (data) => {
|
|
process.send(data);
|
|
});
|
|
} else {
|
|
assert.throws(
|
|
() => cp.fork(__filename, { stdio: ['pipe', 'pipe', 'pipe', 'pipe'] }),
|
|
{ code: 'ERR_CHILD_PROCESS_IPC_REQUIRED', name: 'Error' });
|
|
|
|
let ipc = '';
|
|
let stderr = '';
|
|
const buf = Buffer.from('data to send via pipe');
|
|
const child = cp.fork(__filename, ['child'], {
|
|
stdio: [0, 'ignore', 'pipe', 'ipc', 'pipe']
|
|
});
|
|
|
|
assert.strictEqual(child.stdout, null);
|
|
|
|
child.on('message', (msg) => {
|
|
ipc += msg;
|
|
|
|
if (ipc === buf.toString()) {
|
|
child.disconnect();
|
|
}
|
|
});
|
|
|
|
child.stderr.on('data', (chunk) => {
|
|
stderr += chunk;
|
|
});
|
|
|
|
child.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
assert.strictEqual(stderr, 'this should not be ignored');
|
|
}));
|
|
|
|
child.stdio[4].write(buf);
|
|
}
|