mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
48 lines
1.7 KiB
JavaScript
48 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
require('../common');
|
|
const assert = require('assert');
|
|
|
|
const b = Buffer.alloc(1, 'a');
|
|
const c = Buffer.alloc(1, 'c');
|
|
const d = Buffer.alloc(2, 'aa');
|
|
const e = new Uint8Array([ 0x61, 0x61 ]); // ASCII 'aa', same as d
|
|
|
|
assert.strictEqual(b.compare(c), -1);
|
|
assert.strictEqual(c.compare(d), 1);
|
|
assert.strictEqual(d.compare(b), 1);
|
|
assert.strictEqual(d.compare(e), 0);
|
|
assert.strictEqual(b.compare(d), -1);
|
|
assert.strictEqual(b.compare(b), 0);
|
|
|
|
assert.strictEqual(Buffer.compare(b, c), -1);
|
|
assert.strictEqual(Buffer.compare(c, d), 1);
|
|
assert.strictEqual(Buffer.compare(d, b), 1);
|
|
assert.strictEqual(Buffer.compare(b, d), -1);
|
|
assert.strictEqual(Buffer.compare(c, c), 0);
|
|
assert.strictEqual(Buffer.compare(e, e), 0);
|
|
assert.strictEqual(Buffer.compare(d, e), 0);
|
|
assert.strictEqual(Buffer.compare(d, b), 1);
|
|
|
|
assert.strictEqual(Buffer.compare(Buffer.alloc(0), Buffer.alloc(0)), 0);
|
|
assert.strictEqual(Buffer.compare(Buffer.alloc(0), Buffer.alloc(1)), -1);
|
|
assert.strictEqual(Buffer.compare(Buffer.alloc(1), Buffer.alloc(0)), 1);
|
|
|
|
assert.throws(() => Buffer.compare(Buffer.alloc(1), 'abc'), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "buf2" argument must be an instance of Buffer or Uint8Array. ' +
|
|
"Received type string ('abc')"
|
|
});
|
|
assert.throws(() => Buffer.compare('abc', Buffer.alloc(1)), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
message: 'The "buf1" argument must be an instance of Buffer or Uint8Array. ' +
|
|
"Received type string ('abc')"
|
|
});
|
|
|
|
assert.throws(() => Buffer.alloc(1).compare('abc'), {
|
|
code: 'ERR_INVALID_ARG_TYPE',
|
|
name: 'TypeError',
|
|
message: 'The "target" argument must be an instance of ' +
|
|
"Buffer or Uint8Array. Received type string ('abc')"
|
|
});
|