mirror of
https://github.com/nodejs/node.git
synced 2024-11-21 10:59:27 +00:00
d7452b7140
Warn when a non-existent property of an unfinished module.exports
object is being accessed, as that very often indicates the presence
of a hard-to-detect and hard-to-debug problem.
This mechanism is only used if `module.exports` is still a
regular object at the point at which the second, circular `require()`
happens.
The downside is that, temporarily, `module.exports` will have a
prototype other than `Object.prototype`, and that there may
be valid uses of accessing non-existent properties of unfinished
`module.exports` objects.
Performance of circular require calls in general is not
noticeably impacted.
confidence improvement accuracy (*) (**) (***)
module/module-loader-circular.js n=10000 3.96 % ±5.12% ±6.82% ±8.89%
Example:
$ cat a.js
'use strict';
const b = require('./b.js');
exports.fn = () => {};
$ cat b.js
'use strict';
const a = require('./a.js');
a.fn();
$ node a.js
(node:1617) Warning: Accessing non-existent property 'fn' of module exports inside circular dependency
/tmp/b.js:4
a.fn();
^
TypeError: a.fn is not a function
at Object.<anonymous> (/tmp/b.js:4:3)
[...]
PR-URL: https://github.com/nodejs/node/pull/29935
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
12 lines
284 B
JavaScript
12 lines
284 B
JavaScript
const assert = require('assert');
|
|
|
|
class Parent {}
|
|
class A extends Parent {}
|
|
|
|
module.exports = A;
|
|
require('./warning-moduleexports-class-b.js');
|
|
process.nextTick(() => {
|
|
assert.strictEqual(module.exports, A);
|
|
assert.strictEqual(Object.getPrototypeOf(module.exports), Parent);
|
|
});
|