Commit Graph

2 Commits

Author SHA1 Message Date
Michaël Zasso
eb53121b77
test: fix Windows compiler warnings in overlapped-checker
Fixes two warnings:
- test\overlapped-checker\main_win.c(37,25): warning : format specifies
  type 'int' but the argument has type 'DWORD' (aka 'unsigned long')
  [-Wformat]
- test\overlapped-checker\main_win.c(9,14): warning : unused variable
  'write_count' [-Wunused-variable]

PR-URL: https://github.com/nodejs/node/pull/52405
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
2024-04-10 21:08:06 +00:00
Thiago Padilha
25b21e478e child_process: add 'overlapped' stdio flag
The 'overlapped' value sets the UV_OVERLAPPED_PIPE libuv flag in the
child process stdio.

Fixes: https://github.com/nodejs/node/issues/29238

PR-URL: https://github.com/nodejs/node/pull/29412
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-01-03 22:40:50 +01:00