Antoine du Hamel
5e5af2947f
tools: add polyfilled option to prefer-primordials rule
...
PR-URL: https://github.com/nodejs/node/pull/55318
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2024-10-17 10:37:54 +00:00
Nathan Baulch
0f375db9c6
tools: fix typos
...
PR-URL: https://github.com/nodejs/node/pull/55061
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-10-15 13:59:49 +00:00
Stefan Stojanovic
27f8d9e9d2
build,win: enable pch for clang-cl
...
Fixes: https://github.com/nodejs/node/issues/55208
PR-URL: https://github.com/nodejs/node/pull/55249
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-10-11 10:28:55 +00:00
Antoine du Hamel
4988bb549e
tools: enforce ordering of error codes in errors.md
...
PR-URL: https://github.com/nodejs/node/pull/55324
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-10-10 17:18:20 +00:00
Aviv Keller
71785889c8
lib: prefer logical assignment
...
PR-URL: https://github.com/nodejs/node/pull/55044
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2024-10-09 06:42:16 +00:00
Aviv Keller
5a3da7b4e4
tools: enforce errors to not be documented in legacy section
...
PR-URL: https://github.com/nodejs/node/pull/55218
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-10-08 16:59:53 +00:00
Node.js GitHub Bot
8dbca2d35b
tools: update gyp-next to 0.18.2
...
PR-URL: https://github.com/nodejs/node/pull/55160
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
2024-10-08 03:15:03 +00:00
dependabot[bot]
b2161d3a13
tools: bump the eslint group in /tools/eslint with 4 updates
...
Bumps the eslint group in /tools/eslint with 4 updates: [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js ), [eslint](https://github.com/eslint/eslint ), [eslint-plugin-jsdoc](https://github.com/gajus/eslint-plugin-jsdoc ) and [globals](https://github.com/sindresorhus/globals ).
Updates `@stylistic/eslint-plugin-js` from 2.7.2 to 2.8.0
- [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases )
- [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v2.8.0/packages/eslint-plugin-js )
Updates `eslint` from 9.9.1 to 9.11.1
- [Release notes](https://github.com/eslint/eslint/releases )
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md )
- [Commits](https://github.com/eslint/eslint/compare/v9.9.1...v9.11.1 )
Updates `eslint-plugin-jsdoc` from 50.2.2 to 50.3.1
- [Release notes](https://github.com/gajus/eslint-plugin-jsdoc/releases )
- [Changelog](https://github.com/gajus/eslint-plugin-jsdoc/blob/main/.releaserc )
- [Commits](https://github.com/gajus/eslint-plugin-jsdoc/compare/v50.2.2...v50.3.1 )
Updates `globals` from 15.9.0 to 15.10.0
- [Release notes](https://github.com/sindresorhus/globals/releases )
- [Commits](https://github.com/sindresorhus/globals/compare/v15.9.0...v15.10.0 )
---
updated-dependencies:
- dependency-name: "@stylistic/eslint-plugin-js"
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: eslint
- dependency-name: eslint
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: eslint
- dependency-name: eslint-plugin-jsdoc
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: eslint
- dependency-name: globals
dependency-type: direct:production
update-type: version-update:semver-minor
dependency-group: eslint
...
Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/55227
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-10-03 18:57:31 +00:00
Aviv Keller
e8127db032
tools: make choco install script more readable
...
PR-URL: https://github.com/nodejs/node/pull/54002
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
2024-09-28 15:39:32 +02:00
dependabot[bot]
779e6bdd5e
tools: bump Rollup from 4.18.1 to 4.22.4 for lint-md
...
Bumps [rollup](https://github.com/rollup/rollup ) from 4.18.1 to 4.22.4.
- [Release notes](https://github.com/rollup/rollup/releases )
- [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rollup/rollup/compare/v4.18.1...v4.22.4 )
---
updated-dependencies:
- dependency-name: rollup
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/55093
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-09-26 16:27:10 +00:00
Aviv Keller
5c22d19f44
lib, tools: remove duplicate requires
...
PR-URL: https://github.com/nodejs/node/pull/54987
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-25 08:51:28 +00:00
Michaël Zasso
0257102299
tools: unlock versions of irrelevant DB deps
...
This essentially reverts e0e0b1a70ehttps://github.com/nodejs/node/pull/55042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-24 21:06:48 +00:00
Aviv Keller
574f2dd517
lib: prefer optional chaining
...
PR-URL: https://github.com/nodejs/node/pull/55045
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2024-09-24 19:48:15 +00:00
Aviv Keller
a1cd3c8777
build: update ruff and add lint-py-fix
...
PR-URL: https://github.com/nodejs/node/pull/54410
Reviewed-By: Christian Clauss <cclauss@me.com>
2024-09-24 15:20:20 +00:00
Aviv Keller
f43424ac2d
tools: remove redudant code from eslint require rule
...
PR-URL: https://github.com/nodejs/node/pull/54892
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-23 20:23:05 +00:00
Aviv Keller
6a52e81260
tools: update error message for ICU in license-builder
...
PR-URL: https://github.com/nodejs/node/pull/54742
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-21 08:55:52 -07:00
Yagiz Nizipli
cde6dccb65
tools: refactor js2c.cc to use c++20
...
PR-URL: https://github.com/nodejs/node/pull/54849
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
2024-09-19 19:21:21 +00:00
Abdirahim Musse
c8c108f9b0
tools: add additonal include dirs for V8 on AIX
...
On AIX, we now include src/wasm/float16.h from within src/utils/utils.h
and src/wasm/float16.h includes additional header files.
PR-URL: https://github.com/nodejs/node/pull/54536
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-09-19 14:25:42 +00:00
dependabot[bot]
59c7c55aad
tools: bump the eslint group in /tools/eslint with 7 updates
...
Bumps the eslint group in /tools/eslint with 7 updates:
| Package | From | To |
| --- | --- | --- |
| `@babel/core` | `7.24.9` | `7.25.2` |
| `@babel/eslint-parser` | `7.25.0` | `7.25.1` |
| `@babel/plugin-syntax-import-attributes` | `7.24.7` | `7.25.6` |
| `@stylistic/eslint-plugin-js` | `2.4.0` | `2.7.2` |
| `eslint` | `9.8.0` | `9.9.1` |
| `eslint-plugin-jsdoc` | `48.8.3` | `50.2.2` |
| `globals` | `15.8.0` | `15.9.0` |
Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54821
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-19 02:00:25 +02:00
Chengzhong Wu
7e00be7650
Revert "build: upgrade clang-format to v18"
...
This reverts commit c3e1c31baahttps://github.com/nodejs/node/pull/54994
Refs: https://github.com/nodejs/node/pull/53957
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-09-18 15:58:34 +00:00
Aviv Keller
c6ae161237
meta: remove unneeded ignore rules from ruff
...
PR-URL: https://github.com/nodejs/node/pull/54360
Reviewed-By: Christian Clauss <cclauss@me.com>
2024-09-18 17:07:37 +02:00
Michaël Zasso
c6269cb069
tools: fix path of abseil file in v8.gyp
...
PR-URL: https://github.com/nodejs/node/pull/54659
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2024-09-17 11:47:08 +00:00
Node.js GitHub Bot
d17fefcd71
tools: update github_reporter to 1.7.1
...
PR-URL: https://github.com/nodejs/node/pull/54951
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-09-17 08:49:58 +00:00
Aviv Keller
c3e1c31baa
build: upgrade clang-format to v18
...
PR-URL: https://github.com/nodejs/node/pull/53957
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-14 14:48:08 +00:00
Stefan Stojanovic
79a33a7433
build,win: enable clang-cl compilation
...
This uses the backported ICU fix needed for compiling with ClangCL.
Refs: https://github.com/nodejs/node/pull/54502
Fixes: https://github.com/nodejs/node/issues/34201
PR-URL: https://github.com/nodejs/node/pull/54655
Refs: https://github.com/nodejs/node/issues/52809
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Steven R Loomis <srl295@gmail.com>
2024-09-09 10:26:00 +00:00
Rafael Gonzaga
46c6f8ce26
tools: add readability/fn_size to filter
...
PR-URL: https://github.com/nodejs/node/pull/54744
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-09-07 22:55:34 +00:00
Aviv Keller
437e168c06
build: don't store eslint locally
...
PR-URL: https://github.com/nodejs/node/pull/54231
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2024-09-06 17:31:45 +00:00
Antoine du Hamel
13d6950a6c
tools: add util scripts to land and rebase PRs
...
PR-URL: https://github.com/nodejs/node/pull/54656
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2024-09-06 09:08:24 +02:00
Rafael Gonzaga
3d954dcf81
tools: remove readability/fn_size rule
...
PR-URL: https://github.com/nodejs/node/pull/54663
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-09-01 19:04:02 +00:00
Joyee Cheung
d98cfcc581
vm: introduce vanilla contexts via vm.constants.DONT_CONTEXTIFY
...
This implements a flavor of vm.createContext() and friends
that creates a context without contextifying its global object.
This is suitable when users want to freeze the context (impossible
when the global is contextified i.e. has interceptors installed)
or speed up the global access if they don't need the interceptor
behavior.
```js
const vm = require('node:vm');
const context = vm.createContext(vm.constants.DONT_CONTEXTIFY);
// In contexts with contextified global objects, this is false.
// In vanilla contexts this is true.
console.log(vm.runInContext('globalThis', context) === context);
// In contexts with contextified global objects, this would throw,
// but in vanilla contexts freezing the global object works.
vm.runInContext('Object.freeze(globalThis);', context);
// In contexts with contextified global objects, freezing throws
// and won't be effective. In vanilla contexts, freezing works
// and prevents scripts from accidentally leaking globals.
try {
vm.runInContext('globalThis.foo = 1; foo;', context);
} catch(e) {
console.log(e); // Uncaught ReferenceError: foo is not defined
}
console.log(context.Array); // [Function: Array]
```
PR-URL: https://github.com/nodejs/node/pull/54394
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-08-29 09:05:03 +00:00
Stefan Stojanovic
ebaabf6a0a
deps: backport ICU-22787 to fix ClangCL on Windows
...
- Floating patch for ICU 75.x
ICU Bug: https://unicode-org.atlassian.net/browse/ICU-22787
Backport of: https://github.com/unicode-org/icu/pull/3023
PR-URL: https://github.com/nodejs/node/pull/54502
Reviewed-By: Steven R Loomis <srl295@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2024-08-27 18:44:05 +00:00
Aviv Keller
3a71ccf6c4
tools: remove unused python files
...
PR-URL: https://github.com/nodejs/node/pull/53928
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2024-08-26 20:43:19 +00:00
Marco Ippolito
cef2047b1f
tools: add swc license
...
PR-URL: https://github.com/nodejs/node/pull/54462
Fixes: https://github.com/nodejs/amaro/issues/49
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2024-08-22 08:48:47 +00:00
Michaël Zasso
64e8646618
tools: update V8 gypfiles for 12.8
...
Refs: 06847fbbd4https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-16 16:05:31 +02:00
Richard Lau
dc352a5ff2
tools: update V8 gypfiles for 12.7
...
Add/remove abseil files introduced by V8 12.7 update found by:
```
git diff-tree --no-commit-id --name-status 0ec8f7eea3https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-16 16:05:13 +02:00
Michaël Zasso
8044051ce3
tools: update V8 gypfiles for 12.6
...
Refs: f8fa22073ahttps://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-16 16:04:30 +02:00
Leszek Swirski
9d0748c5df
build: disable ICF for mksnapshot
...
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/5447267
Co-authored-by: Michaël Zasso <targos@protonmail.com>
PR-URL: https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-16 16:04:25 +02:00
Michaël Zasso
b7bcf3e121
build: include v8-sandbox.h header in distribution
...
Refs: 5495678083https://github.com/nodejs/node/pull/54077
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-08-16 16:04:18 +02:00
Michaël Zasso
2573f74b0d
build: always disable strict aliasing
...
V8 relies on it.
PR-URL: https://github.com/nodejs/node/pull/54339
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2024-08-14 18:33:43 +00:00
Aviv Keller
53c5322c6a
tools: remove header from c-ares license
...
PR-URL: https://github.com/nodejs/node/pull/54335
Refs: 595cf21334
2024-08-14 15:43:24 +00:00
Marco Ippolito
9e8cc2933e
tools: add find pyenv path on windows
...
PR-URL: https://github.com/nodejs/node/pull/54314
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2024-08-13 08:24:54 +00:00
Michael Dawson
e9deab9915
tools: make undici updater build wasm from src
...
- modify updater to include all files required to rebuild
wasm from what's stored in the deps/undici directory
- modify updater to build wasm from source while updating
Signed-off-by: Michael Dawson <mdawson@devrus.com>
PR-URL: https://github.com/nodejs/node/pull/54128
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
2024-08-07 16:57:26 -04:00
Antoine du Hamel
b47aa708a8
tools: add workflow to ensure README lists are in sync with gh teams
...
PR-URL: https://github.com/nodejs/node/pull/53901
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2024-08-06 13:50:27 +00:00
Node.js GitHub Bot
4d1cc7618e
tools: update eslint to 9.8.0
...
PR-URL: https://github.com/nodejs/node/pull/54073
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2024-07-30 16:56:04 +02:00
Michaël Zasso
a5decd4c8d
build: drop experimental support for Windows <10
...
V8 now uses Windows APIs that are not available in older Windows
versions.
PR-URL: https://github.com/nodejs/node/pull/54079
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2024-07-30 12:29:17 +00:00
Chengzhong Wu
05a9413527
node-api: add property keys benchmark
...
PR-URL: https://github.com/nodejs/node/pull/54012
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2024-07-29 11:19:52 +00:00
Marco Ippolito
35f92d953c
module: add --experimental-strip-types
...
PR-URL: https://github.com/nodejs/node/pull/53725
Refs: https://github.com/nodejs/loaders/issues/217
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
2024-07-24 16:30:06 +00:00
Chengzhong Wu
e192a32c27
build: fix conflict gyp configs
...
Gyp generated build files can be built in either Release/Debug mode.
- make: single directory, two configurations by cli:
`make -C out BUILDTYPE=Release` and `make -C out BUILDTYPE=Debug`.
- msbuild: single directory, two configurations by cli:
`msbuild node.sln /p:Configuration=Release` and
`msbuild node.sln /p:Configuration=Debug`.
- ninja: two directories in `out/`, build with
`ninja -C out/Release` or `ninja -C out/Debug`.
Variables that changes with either Release or Debug configuration
should be defined in a configuration level, instead of the root level.
This fixes generating invalid build files.
Additionally, `v8_gypfiles/toolchain.gypi` duplicates defines in
`v8_gypfiles/features.gypi`. Remove the duplications in
`toolchains.gypi`
PR-URL: https://github.com/nodejs/node/pull/53605
Fixes: https://github.com/nodejs/node/issues/53446
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-23 08:56:44 +00:00
Aviv Keller
1c5fe040a0
meta: remove license for hljs
...
PR-URL: https://github.com/nodejs/node/pull/53970
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2024-07-22 16:54:32 +00:00
Richard Lau
7fb65f6bd0
build, tools: drop leading / from r2dir
...
The script is commented as removing `/home/dist/` part but the `cut`
command is off by one and end up including the `/` character (so that
the resulting string starts with `/`). When this is substituted into
`s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
`//` (one from the template and one from the `r2dir`) which appears
to cause Cloudflare to create an extra top level `/` directory in the
bucket.
PR-URL: https://github.com/nodejs/node/pull/53951
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2024-07-22 13:21:35 +00:00
