Commit Graph

4 Commits

Author SHA1 Message Date
João Reis
7bff96204b build,win: fix Python detection on localized OS
This code previously assumed the default value was always printed to
the console by reg.exe as "(default)", but this is not true on
localized versions of Windows and can contain spaces.

Fixes: https://github.com/nodejs/node/issues/29417

PR-URL: https://github.com/nodejs/node/pull/29423
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
2019-09-05 19:14:29 -07:00
Rod Vagg
e25a17517b src: limit .gitattributes eol to vcbuild.bat
Fixes: https://github.com/iojs/io.js/issues/330
PR-URL: https://github.com/iojs/io.js/pull/331
2015-01-13 22:33:52 +11:00
Rod Vagg
43e4c906e2 src: rename node to io.js for Windows installer
* quote "NODE_VERSION_STRING" in node.rc to allow for complex version
  strings
* change user-facing strings
* make sure .bat files are crlf

PR-URL: https://github.com/iojs/io.js/pull/291
Reviewed-By: Bert Belder <bertbelder@gmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
2015-01-13 09:44:34 +11:00
Bert Belder
43da0e6fe4 Explicitly disable cr/lf conversion for test fixtures
Otherwise git's autocrlf feature makes test fail on windows.
2011-08-10 19:59:37 +02:00