Commit Graph

3 Commits

Author SHA1 Message Date
Stefan Stojanovic
1ba508d51b
win,tools: upgrade Windows signing to smctl
As a part of the new signing requrements for Windows change approach to
use the DigiCert cloud HSM service KeyLocker.

PR-URL: https://github.com/nodejs/node/pull/50956
Fixes: https://github.com/nodejs/build/issues/3491
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2023-12-08 21:58:17 +00:00
Tobias Nießen
6311de3322
tools: upgrade Windows digital signature to SHA256
signtool still defaults to SHA1, which is vulnerable to certain
collisions. This switches to SHA256, which is stronger and which also
matches the hash function used by the signing certificate.

Technically, `/fd certHash` would be a better choice, but I don't know
if it is widely supported.

PR-URL: https://github.com/nodejs/node/pull/47206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-03-25 18:27:46 +00:00
Rod Vagg
7014566273 win,build: try multiple timeservers when signing
PR-URL: https://github.com/nodejs/node/pull/9155
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: João Reis <reis@janeasystems.com>
2016-10-19 00:11:02 +11:00