Commit Graph

6 Commits

Author SHA1 Message Date
Livia Medeiros
052434a0c1
test: use tmpdir.resolve()
PR-URL: https://github.com/nodejs/node/pull/49136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-08-21 16:41:53 +00:00
Moshe Atlow
9dc2d1b964
test: fix flaky test-watch-mode
PR-URL: https://github.com/nodejs/node/pull/48147
Fixes: https://github.com/nodejs/node/issues/44898
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2023-06-08 11:35:14 +00:00
Moshe Atlow
ce16bf553f
watch: watch for missing dependencies
PR-URL: https://github.com/nodejs/node/pull/45348
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
2022-11-13 15:13:26 +00:00
Richard Lau
9ceac979a1
test: use common/tmpdir in watch-mode ipc test
Using `path.join(os.tmpdir(), 'file')` on a multi-user system can lead
to file collisions where the file already exists but is owned by a
different user and cannot be removed or overwritten. Other tests in
`parallel/test-watch-mode-files_watcher` use `common/tmpdir` instead
so switch to that for consistency.

PR-URL: https://github.com/nodejs/node/pull/45211
Refs: https://github.com/nodejs/node/pull/44366
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
2022-10-28 11:29:41 +00:00
Moshe Atlow
96f072231d test: deflake watch mode tests
PR-URL: https://github.com/nodejs/node/pull/44621
Fixes: https://github.com/nodejs/node/issues/44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2022-09-20 10:37:42 +03:00
Moshe Atlow
beb0520af7 cli: add --watch
PR-URL: https://github.com/nodejs/node/pull/44366
Fixes: https://github.com/nodejs/node/issues/40429
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-09-05 12:25:09 +03:00