From fe1dd26398e1887b96b2dc51ab59371ad4d6bc20 Mon Sep 17 00:00:00 2001 From: Richard Lau Date: Sun, 10 Nov 2024 19:20:50 +0000 Subject: [PATCH] build: use glob for dependencies of out/Makefile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `out/Makefile` target in `Makefile` has an incomplete list of `.gyp` files for Node.js dependencies in `deps`, but also the ones that are listed are unconditional. If using any of the `--shared-*` configure options, it should be possible to still build Node.js if the corresponding directory under `deps` is removed. Convert the explicit list of dependency `*.gyp` files for the `out/Makefile` target to a glob. This will pick up any toplevel `.gyp` files for dependencies present in `deps`. PR-URL: https://github.com/nodejs/node/pull/55789 Reviewed-By: Luigi Pinca Reviewed-By: Yagiz Nizipli Reviewed-By: Juan José Arboleda --- Makefile | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 8ef45d9a7bd..4fa275a1b33 100644 --- a/Makefile +++ b/Makefile @@ -171,8 +171,7 @@ with-code-cache test-code-cache: $(warning '$@' target is a noop) out/Makefile: config.gypi common.gypi node.gyp \ - deps/uv/uv.gyp deps/llhttp/llhttp.gyp deps/zlib/zlib.gyp \ - deps/simdutf/simdutf.gyp deps/ada/ada.gyp deps/nbytes/nbytes.gyp \ + deps/*/*.gyp \ tools/v8_gypfiles/toolchain.gypi \ tools/v8_gypfiles/features.gypi \ tools/v8_gypfiles/inspector.gypi tools/v8_gypfiles/v8.gyp