benchmark: use tmpdir.resolve()

PR-URL: https://github.com/nodejs/node/pull/49137
Refs: https://github.com/nodejs/node/pull/49079
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

benchmark/esm/cjs-parse.js

@@ -5,8 +5,7 @@ const common = require('../common.js');
 const { strictEqual } = require('assert');
 
 const tmpdir = require('../../test/common/tmpdir');
-const benchmarkDirectory =
+const benchmarkDirectory = tmpdir.resolve('benchmark-esm-parse');
-  path.resolve(tmpdir.path, 'benchmark-esm-parse');
 
 const bench = common.createBenchmark(main, {
   n: [1e2],

benchmark/esm/esm-legacyMainResolve.js

@@ -8,8 +8,7 @@ const common = require('../common.js');
 const tmpdir = require('../../test/common/tmpdir.js');
 const { pathToFileURL } = require('node:url');
 
-const benchmarkDirectory =
+const benchmarkDirectory = tmpdir.resolve('benchmark-import-meta-resolve');
-  path.resolve(tmpdir.path, 'benchmark-import-meta-resolve');
 
 const configs = {
   n: [1e4],

benchmark/esm/esm-loader-defaultResolve.js

@@ -8,8 +8,7 @@ const common = require('../common.js');
 const tmpdir = require('../../test/common/tmpdir.js');
 const { pathToFileURL } = require('node:url');
 
-const benchmarkDirectory =
+const benchmarkDirectory = tmpdir.resolve('benchmark-import-meta-resolve');
-  path.resolve(tmpdir.path, 'benchmark-import-meta-resolve');
 
 const parentURL = pathToFileURL(path.join(benchmarkDirectory, 'entry-point.js'));
 

benchmark/fs/read-stream-throughput.js

@@ -1,15 +1,13 @@
 // Test the throughput of the fs.WriteStream class.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 const assert = require('assert');
 
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 
 const bench = common.createBenchmark(main, {
   encodingType: ['buf', 'asc', 'utf'],

benchmark/fs/readfile-permission-enabled.js

@@ -3,15 +3,13 @@
 // Then see how many times it got called.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 const assert = require('assert');
 
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 
 const bench = common.createBenchmark(main, {
   duration: [5],

benchmark/fs/readfile-promises.js

@@ -3,15 +3,13 @@
 // Yes, this is a silly benchmark.  Most benchmarks are silly.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 const assert = require('assert');
 
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 
 const bench = common.createBenchmark(main, {
   duration: [5],

benchmark/fs/readfile.js

@@ -3,15 +3,13 @@
 // Yes, this is a silly benchmark.  Most benchmarks are silly.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 const assert = require('assert');
 
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 
 const bench = common.createBenchmark(main, {
   duration: [5],

benchmark/fs/write-stream-throughput.js

@@ -1,14 +1,12 @@
 // Test the throughput of the fs.WriteStream class.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 
 const tmpdir = require('../../test/common/tmpdir');
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 
 const bench = common.createBenchmark(main, {
   dur: [5],

benchmark/fs/writefile-promises.js

@@ -3,15 +3,13 @@
 // Yes, this is a silly benchmark.  Most benchmarks are silly.
 'use strict';
 
-const path = require('path');
 const common = require('../common.js');
 const fs = require('fs');
 const assert = require('assert');
 const tmpdir = require('../../test/common/tmpdir');
 
 tmpdir.refresh();
-const filename = path.resolve(tmpdir.path,
+const filename = tmpdir.resolve(`.removeme-benchmark-garbage-${process.pid}`);
-                              `.removeme-benchmark-garbage-${process.pid}`);
 let filesWritten = 0;
 const bench = common.createBenchmark(main, {
   duration: [5],

benchmark/module/module-loader-circular.js

@@ -4,8 +4,7 @@ const path = require('path');
 const common = require('../common.js');
 
 const tmpdir = require('../../test/common/tmpdir');
-const benchmarkDirectory =
+const benchmarkDirectory = tmpdir.resolve('benchmark-module-circular');
-  path.resolve(tmpdir.path, 'benchmark-module-circular');
 
 const bench = common.createBenchmark(main, {
   n: [1e4],

benchmark/module/module-loader-deep.js

@@ -1,10 +1,9 @@
 'use strict';
 const fs = require('fs');
-const path = require('path');
 const common = require('../common.js');
 
 const tmpdir = require('../../test/common/tmpdir');
-const benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
+const benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
 
 const bench = common.createBenchmark(main, {
   ext: ['', '.js'],

benchmark/module/module-loader.js

@@ -5,7 +5,7 @@ const { builtinModules } = require('module');
 const common = require('../common.js');
 
 const tmpdir = require('../../test/common/tmpdir');
-let benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
+let benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
 
 // Filter all irregular modules.
 const otherModules = builtinModules.filter((name) => !/\/|^_|^sys/.test(name));

benchmark/module/module-require.js

@@ -1,10 +1,9 @@
 'use strict';
 
 const fs = require('fs');
-const path = require('path');
 const common = require('../common.js');
 const tmpdir = require('../../test/common/tmpdir');
-const benchmarkDirectory = path.join(tmpdir.path, 'nodejs-benchmark-module');
+const benchmarkDirectory = tmpdir.resolve('nodejs-benchmark-module');
 
 const bench = common.createBenchmark(main, {
   type: ['.js', '.json', 'dir'],

benchmark/process/coverage.js

@@ -6,12 +6,11 @@ const common = require('../common.js');
 const bench = common.createBenchmark(main, {
   n: [1e5],
 });
-const path = require('path');
 const { rmSync } = require('fs');
 const { spawnSync } = require('child_process');
 const tmpdir = require('../../test/common/tmpdir');
 
-const coverageDir = path.join(tmpdir.path, `./cov-${Date.now()}`);
+const coverageDir = tmpdir.resolve(`cov-${Date.now()}`);
 
 function main({ n }) {
   bench.start();