diff --git a/doc/api/diagnostics_channel.md b/doc/api/diagnostics_channel.md index ce2aae7705f..0ec452bec3d 100644 --- a/doc/api/diagnostics_channel.md +++ b/doc/api/diagnostics_channel.md @@ -1117,6 +1117,58 @@ Emitted when server receives a request. Emitted when server sends a response. +#### Modules + +`module.require.start` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `require()`. Module name. + * `parentFilename` - Name of the module that attempted to require(id). + +Emitted when `require()` is executed. See [`start` event][]. + +`module.require.end` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `require()`. Module name. + * `parentFilename` - Name of the module that attempted to require(id). + +Emitted when a `require()` call returns. See [`end` event][]. + +`module.require.error` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `require()`. Module name. + * `parentFilename` - Name of the module that attempted to require(id). +* `error` {Error} + +Emitted when a `require()` throws an error. See [`error` event][]. + +`module.import.asyncStart` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `import()`. Module name. + * `parentURL` - URL object of the module that attempted to import(id). + +Emitted when `import()` is invoked. See [`asyncStart` event][]. + +`module.import.asyncEnd` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `import()`. Module name. + * `parentURL` - URL object of the module that attempted to import(id). + +Emitted when `import()` has completed. See [`asyncEnd` event][]. + +`module.import.error` + +* `event` {Object} containing the following properties + * `id` - Argument passed to `import()`. Module name. + * `parentURL` - URL object of the module that attempted to import(id). +* `error` {Error} + +Emitted when a `import()` throws an error. See [`error` event][]. + #### NET `net.client.socket` diff --git a/lib/diagnostics_channel.js b/lib/diagnostics_channel.js index dc26dc735a0..59a95b08226 100644 --- a/lib/diagnostics_channel.js +++ b/lib/diagnostics_channel.js @@ -269,7 +269,8 @@ function tracingChannelFrom(nameOrChannels, name) { class TracingChannel { constructor(nameOrChannels) { - for (const eventName of traceEvents) { + for (let i = 0; i < traceEvents.length; ++i) { + const eventName = traceEvents[i]; ObjectDefineProperty(this, eventName, { __proto__: null, value: tracingChannelFrom(nameOrChannels, eventName), @@ -278,15 +279,16 @@ class TracingChannel { } get hasSubscribers() { - return this.start.hasSubscribers || - this.end.hasSubscribers || - this.asyncStart.hasSubscribers || - this.asyncEnd.hasSubscribers || - this.error.hasSubscribers; + return this.start?.hasSubscribers || + this.end?.hasSubscribers || + this.asyncStart?.hasSubscribers || + this.asyncEnd?.hasSubscribers || + this.error?.hasSubscribers; } subscribe(handlers) { - for (const name of traceEvents) { + for (let i = 0; i < traceEvents.length; ++i) { + const name = traceEvents[i]; if (!handlers[name]) continue; this[name]?.subscribe(handlers[name]); @@ -296,7 +298,8 @@ class TracingChannel { unsubscribe(handlers) { let done = true; - for (const name of traceEvents) { + for (let i = 0; i < traceEvents.length; ++i) { + const name = traceEvents[i]; if (!handlers[name]) continue; if (!this[name]?.unsubscribe(handlers[name])) { diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js index ffc9d94834a..61286fe760b 100644 --- a/lib/internal/modules/cjs/loader.js +++ b/lib/internal/modules/cjs/loader.js @@ -189,6 +189,9 @@ let { startTimer, endTimer } = debugWithTimer('module_timer', (start, end) => { endTimer = end; }); +const { tracingChannel } = require('diagnostics_channel'); +const onRequire = getLazy(() => tracingChannel('module.require')); + const isWindows = process.platform === 'win32'; const relativeResolveCache = { __proto__: null }; @@ -209,7 +212,11 @@ function wrapModuleLoad(request, parent, isMain) { startTimer(logLabel, traceLabel); try { - return Module._load(request, parent, isMain); + return onRequire().traceSync(Module._load, { + __proto__: null, + parentFilename: parent?.filename, + id: request, + }, Module, request, parent, isMain); } finally { endTimer(logLabel, traceLabel); } diff --git a/lib/internal/modules/esm/loader.js b/lib/internal/modules/esm/loader.js index f3bde49d64c..231f7308e65 100644 --- a/lib/internal/modules/esm/loader.js +++ b/lib/internal/modules/esm/loader.js @@ -42,6 +42,9 @@ const { } = require('internal/modules/helpers'); let defaultResolve, defaultLoad, defaultLoadSync, importMetaInitializer; +const { tracingChannel } = require('diagnostics_channel'); +const onImport = tracingChannel('module.import'); + /** * @typedef {import('url').URL} URL */ @@ -210,10 +213,17 @@ class ModuleLoader { return compileSourceTextModule(url, source, this); }; const { ModuleJob } = require('internal/modules/esm/module_job'); - const job = new ModuleJob( - this, url, undefined, evalInstance, false, false); - this.loadCache.set(url, undefined, job); - const { module } = await job.run(isEntryPoint); + const module = await onImport.tracePromise(async () => { + const job = new ModuleJob( + this, url, undefined, evalInstance, false, false); + this.loadCache.set(url, undefined, job); + const { module } = await job.run(isEntryPoint); + return module; + }, { + __proto__: null, + parentURL: '', + url, + }); return { __proto__: null, @@ -470,9 +480,15 @@ class ModuleLoader { * @returns {Promise} */ async import(specifier, parentURL, importAttributes, isEntryPoint = false) { - const moduleJob = await this.getModuleJob(specifier, parentURL, importAttributes); - const { module } = await moduleJob.run(isEntryPoint); - return module.getNamespace(); + return onImport.tracePromise(async () => { + const moduleJob = await this.getModuleJob(specifier, parentURL, importAttributes); + const { module } = await moduleJob.run(isEntryPoint); + return module.getNamespace(); + }, { + __proto__: null, + parentURL, + url: specifier, + }); } /** diff --git a/test/fixtures/console/console.snapshot b/test/fixtures/console/console.snapshot index 4f1cb254811..41e7d16fb99 100644 --- a/test/fixtures/console/console.snapshot +++ b/test/fixtures/console/console.snapshot @@ -7,3 +7,4 @@ Trace: foo at * at * at * + at * diff --git a/test/fixtures/errors/force_colors.snapshot b/test/fixtures/errors/force_colors.snapshot index 21410d492db..e5a03ca6094 100644 --- a/test/fixtures/errors/force_colors.snapshot +++ b/test/fixtures/errors/force_colors.snapshot @@ -11,5 +11,6 @@ Error: Should include grayed stack trace  at *  at *  at * + at * Node.js * diff --git a/test/fixtures/errors/promise_unhandled_warn_with_error.snapshot b/test/fixtures/errors/promise_unhandled_warn_with_error.snapshot index 48e5da7c9ad..6acc3fd2b80 100644 --- a/test/fixtures/errors/promise_unhandled_warn_with_error.snapshot +++ b/test/fixtures/errors/promise_unhandled_warn_with_error.snapshot @@ -7,5 +7,6 @@ at * at * at * + at * (Use `node --trace-warnings ...` to show where the warning was created) (node:*) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https:*nodejs.org*api*cli.html#cli_unhandled_rejections_mode). (rejection id: 1) diff --git a/test/fixtures/errors/unhandled_promise_trace_warnings.snapshot b/test/fixtures/errors/unhandled_promise_trace_warnings.snapshot index 94c709b1778..246b82a8d5a 100644 --- a/test/fixtures/errors/unhandled_promise_trace_warnings.snapshot +++ b/test/fixtures/errors/unhandled_promise_trace_warnings.snapshot @@ -11,6 +11,7 @@ at * at * at * + at * (node:*) Error: This was rejected at * at * @@ -20,6 +21,7 @@ at * at * at * + at * (node:*) PromiseRejectionHandledWarning: Promise rejection was handled asynchronously (rejection id: 1) at * at * diff --git a/test/message/assert_throws_stack.out b/test/message/assert_throws_stack.out index 652a60532c6..b1f3ea2108b 100644 --- a/test/message/assert_throws_stack.out +++ b/test/message/assert_throws_stack.out @@ -16,6 +16,7 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal: at * at * at * + at * at * { generatedMessage: true, code: 'ERR_ASSERTION', diff --git a/test/message/internal_assert.out b/test/message/internal_assert.out index e4f67f650f9..87aaab00370 100644 --- a/test/message/internal_assert.out +++ b/test/message/internal_assert.out @@ -13,6 +13,7 @@ Please open an issue with this stack trace at https://github.com/nodejs/node/iss at * at * at * + at * at * { code: 'ERR_INTERNAL_ASSERTION' } diff --git a/test/message/internal_assert_fail.out b/test/message/internal_assert_fail.out index 6a5916401bb..9fc86673262 100644 --- a/test/message/internal_assert_fail.out +++ b/test/message/internal_assert_fail.out @@ -14,6 +14,7 @@ Please open an issue with this stack trace at https://github.com/nodejs/node/iss at * at * at * + at * at * { code: 'ERR_INTERNAL_ASSERTION' } diff --git a/test/message/util-inspect-error-cause.out b/test/message/util-inspect-error-cause.out index 344ace1bc94..6e2caf7f051 100644 --- a/test/message/util-inspect-error-cause.out +++ b/test/message/util-inspect-error-cause.out @@ -6,6 +6,7 @@ Error: Number error cause at * at * at * + at * at * { [cause]: 42 } @@ -17,6 +18,7 @@ Error: Object cause at * at * at * + at * at * { [cause]: { message: 'Unique', @@ -33,6 +35,7 @@ Error: undefined cause at * at * at * + at * at * { [cause]: undefined } @@ -44,6 +47,7 @@ Error: cause that throws at * at * at * + at * at * { [cause]: [Getter] } @@ -53,7 +57,7 @@ RangeError: New Stack Frames [cause]: FoobarError: Individual message at * *[90m at *[39m - *[90m ... 5 lines matching cause stack trace ...*[39m + *[90m ... 6 lines matching cause stack trace ...*[39m *[90m at *[39m { status: *[32m'Feeling good'*[39m, extraProperties: *[32m'Yes!'*[39m, @@ -66,17 +70,18 @@ RangeError: New Stack Frames *[90m at *[39m *[90m at *[39m *[90m at *[39m + *[90m at *[39m } } Error: Stack causes at * *[90m at *[39m -*[90m ... 5 lines matching cause stack trace ...*[39m +*[90m ... 6 lines matching cause stack trace ...*[39m *[90m at *[39m { [cause]: FoobarError: Individual message at * *[90m at *[39m - *[90m ... 5 lines matching cause stack trace ...*[39m + *[90m ... 6 lines matching cause stack trace ...*[39m *[90m at *[39m { status: *[32m'Feeling good'*[39m, extraProperties: *[32m'Yes!'*[39m, @@ -89,6 +94,7 @@ Error: Stack causes *[90m at *[39m *[90m at *[39m *[90m at *[39m + *[90m at *[39m } } RangeError: New Stack Frames @@ -97,12 +103,12 @@ RangeError: New Stack Frames [cause]: Error: Stack causes at * *[90m at *[39m - *[90m ... 5 lines matching cause stack trace ...*[39m + *[90m ... 6 lines matching cause stack trace ...*[39m *[90m at *[39m { [cause]: FoobarError: Individual message at * *[90m at *[39m - *[90m ... 5 lines matching cause stack trace ...*[39m + *[90m ... 6 lines matching cause stack trace ...*[39m *[90m at *[39m { status: *[32m'Feeling good'*[39m, extraProperties: *[32m'Yes!'*[39m, @@ -115,6 +121,7 @@ RangeError: New Stack Frames *[90m at *[39m *[90m at *[39m *[90m at *[39m + *[90m at *[39m } } } @@ -124,7 +131,7 @@ RangeError: New Stack Frames [cause]: FoobarError: Individual message at * at * - ... 5 lines matching cause stack trace ... + ... 6 lines matching cause stack trace ... at * { status: 'Feeling good', extraProperties: 'Yes!', @@ -137,17 +144,18 @@ RangeError: New Stack Frames at * at * at * + at * } } Error: Stack causes at * at * - ... 5 lines matching cause stack trace ... + ... 6 lines matching cause stack trace ... at * { [cause]: FoobarError: Individual message at * at * - ... 5 lines matching cause stack trace ... + ... 6 lines matching cause stack trace ... at * status: 'Feeling good', extraProperties: 'Yes!', @@ -160,6 +168,7 @@ Error: Stack causes at * at * at * + at * } } RangeError: New Stack Frames @@ -168,12 +177,12 @@ RangeError: New Stack Frames [cause]: Error: Stack causes at * at * - ... 5 lines matching cause stack trace ... + ... 6 lines matching cause stack trace ... at * { [cause]: FoobarError: Individual message at * at * - ... 5 lines matching cause stack trace ... + ... 6 lines matching cause stack trace ... at * { status: 'Feeling good', extraProperties: 'Yes!', @@ -186,6 +195,7 @@ RangeError: New Stack Frames at * at * at * + at * } } } diff --git a/test/message/util_inspect_error.out b/test/message/util_inspect_error.out index 31b65eb2e2b..0af1853adde 100644 --- a/test/message/util_inspect_error.out +++ b/test/message/util_inspect_error.out @@ -9,6 +9,7 @@ at * at * at * + at * nested: { err: Error: foo @@ -21,6 +22,7 @@ at * at * at * + at * { err: Error: foo bar @@ -32,6 +34,7 @@ at * at * at * + at * nested: { err: Error: foo bar @@ -43,6 +46,7 @@ at * at * at * + at * } } { Error: foo @@ -55,4 +59,5 @@ bar at * at * at * + at * foo: 'bar' } diff --git a/test/parallel/test-bootstrap-modules.js b/test/parallel/test-bootstrap-modules.js index 6327fbeb2e7..a21c514d44c 100644 --- a/test/parallel/test-bootstrap-modules.js +++ b/test/parallel/test-bootstrap-modules.js @@ -98,6 +98,7 @@ expected.beforePreExec = new Set([ 'NativeModule internal/modules/package_json_reader', 'Internal Binding module_wrap', 'NativeModule internal/modules/cjs/loader', + 'NativeModule diagnostics_channel', 'Internal Binding wasm_web_api', 'NativeModule internal/events/abort_listener', ]); @@ -162,11 +163,11 @@ if (process.features.inspector) { expected.beforePreExec.add('Internal Binding inspector'); expected.beforePreExec.add('NativeModule internal/util/inspector'); expected.atRunTime.add('NativeModule internal/inspector_async_hook'); +} - // This is loaded if the test is run with NODE_V8_COVERAGE. - if (process.env.NODE_V8_COVERAGE) { - expected.atRunTime.add('Internal Binding profiler'); - } +// This is loaded if the test is run with NODE_V8_COVERAGE. +if (process.env.NODE_V8_COVERAGE) { + expected.atRunTime.add('Internal Binding profiler'); } const difference = (setA, setB) => { diff --git a/test/parallel/test-diagnostics-channel-module-import-error.js b/test/parallel/test-diagnostics-channel-module-import-error.js new file mode 100644 index 00000000000..f3518e8fc55 --- /dev/null +++ b/test/parallel/test-diagnostics-channel-module-import-error.js @@ -0,0 +1,69 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const dc = require('diagnostics_channel'); + +const trace = dc.tracingChannel('module.import'); +const events = []; +let lastEvent; + +function track(name) { + return (event) => { + // Verify every event after the first is the same object + if (events.length) { + assert.strictEqual(event, lastEvent); + } + lastEvent = event; + + events.push({ name, ...event }); + }; +} + +trace.subscribe({ + start: common.mustCall(track('start')), + end: common.mustCall(track('end')), + asyncStart: common.mustCall(track('asyncStart')), + asyncEnd: common.mustCall(track('asyncEnd')), + error: common.mustCall(track('error')), +}); + +import('does-not-exist').then( + common.mustNotCall(), + common.mustCall((error) => { + let expectedParentURL = module.filename.replaceAll('\\', '/'); + expectedParentURL = common.isWindows ? + `file:///${expectedParentURL}` : + `file://${expectedParentURL}`; + // Verify order and contents of each event + assert.deepStrictEqual(events, [ + { + name: 'start', + parentURL: expectedParentURL, + url: 'does-not-exist', + }, + { + name: 'end', + parentURL: expectedParentURL, + url: 'does-not-exist', + }, + { + name: 'error', + parentURL: expectedParentURL, + url: 'does-not-exist', + error, + }, + { + name: 'asyncStart', + parentURL: expectedParentURL, + url: 'does-not-exist', + error, + }, + { + name: 'asyncEnd', + parentURL: expectedParentURL, + url: 'does-not-exist', + error, + }, + ]); + }) +); diff --git a/test/parallel/test-diagnostics-channel-module-import.js b/test/parallel/test-diagnostics-channel-module-import.js new file mode 100644 index 00000000000..51ca24ed3d4 --- /dev/null +++ b/test/parallel/test-diagnostics-channel-module-import.js @@ -0,0 +1,63 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const dc = require('diagnostics_channel'); + +const trace = dc.tracingChannel('module.import'); +const events = []; +let lastEvent; + +function track(name) { + return (event) => { + // Verify every event after the first is the same object + if (events.length) { + assert.strictEqual(event, lastEvent); + } + lastEvent = event; + + events.push({ name, ...event }); + }; +} + +trace.subscribe({ + start: common.mustCall(track('start')), + end: common.mustCall(track('end')), + asyncStart: common.mustCall(track('asyncStart')), + asyncEnd: common.mustCall(track('asyncEnd')), + error: common.mustNotCall(track('error')), +}); + +import('http').then( + common.mustCall((result) => { + let expectedParentURL = module.filename.replaceAll('\\', '/'); + expectedParentURL = common.isWindows ? + `file:///${expectedParentURL}` : + `file://${expectedParentURL}`; + // Verify order and contents of each event + assert.deepStrictEqual(events, [ + { + name: 'start', + parentURL: expectedParentURL, + url: 'http', + }, + { + name: 'end', + parentURL: expectedParentURL, + url: 'http', + }, + { + name: 'asyncStart', + parentURL: expectedParentURL, + url: 'http', + result, + }, + { + name: 'asyncEnd', + parentURL: expectedParentURL, + url: 'http', + result, + }, + ]); + }), + common.mustNotCall(), +); diff --git a/test/parallel/test-diagnostics-channel-module-require-error.js b/test/parallel/test-diagnostics-channel-module-require-error.js new file mode 100644 index 00000000000..5eeb76223c4 --- /dev/null +++ b/test/parallel/test-diagnostics-channel-module-require-error.js @@ -0,0 +1,56 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const dc = require('diagnostics_channel'); + +const trace = dc.tracingChannel('module.require'); +const events = []; +let lastEvent; + +function track(name) { + return (event) => { + // Verify every event after the first is the same object + if (events.length) { + assert.strictEqual(event, lastEvent); + } + lastEvent = event; + + events.push({ name, ...event }); + }; +} + +trace.subscribe({ + start: common.mustCall(track('start')), + end: common.mustCall(track('end')), + asyncStart: common.mustNotCall(track('asyncStart')), + asyncEnd: common.mustNotCall(track('asyncEnd')), + error: common.mustCall(track('error')), +}); + +let error; +try { + require('does-not-exist'); +} catch (err) { + error = err; +} + +// Verify order and contents of each event +assert.deepStrictEqual(events, [ + { + name: 'start', + parentFilename: module.filename, + id: 'does-not-exist', + }, + { + name: 'error', + parentFilename: module.filename, + id: 'does-not-exist', + error, + }, + { + name: 'end', + parentFilename: module.filename, + id: 'does-not-exist', + error, + }, +]); diff --git a/test/parallel/test-diagnostics-channel-module-require.js b/test/parallel/test-diagnostics-channel-module-require.js new file mode 100644 index 00000000000..6d64f4fc675 --- /dev/null +++ b/test/parallel/test-diagnostics-channel-module-require.js @@ -0,0 +1,45 @@ +'use strict'; +const common = require('../common'); +const assert = require('assert'); +const dc = require('diagnostics_channel'); + +const trace = dc.tracingChannel('module.require'); +const events = []; +let lastEvent; + +function track(name) { + return (event) => { + // Verify every event after the first is the same object + if (events.length) { + assert.strictEqual(event, lastEvent); + } + lastEvent = event; + + events.push({ name, ...event }); + }; +} + +trace.subscribe({ + start: common.mustCall(track('start')), + end: common.mustCall(track('end')), + asyncStart: common.mustNotCall(track('asyncStart')), + asyncEnd: common.mustNotCall(track('asyncEnd')), + error: common.mustNotCall(track('error')), +}); + +const result = require('http'); + +// Verify order and contents of each event +assert.deepStrictEqual(events, [ + { + name: 'start', + parentFilename: module.filename, + id: 'http', + }, + { + name: 'end', + parentFilename: module.filename, + id: 'http', + result, + }, +]); diff --git a/test/parallel/test-domain-set-uncaught-exception-capture-after-load.js b/test/parallel/test-domain-set-uncaught-exception-capture-after-load.js index 55e2e5368d7..4bf419d76eb 100644 --- a/test/parallel/test-domain-set-uncaught-exception-capture-after-load.js +++ b/test/parallel/test-domain-set-uncaught-exception-capture-after-load.js @@ -2,6 +2,8 @@ const common = require('../common'); const assert = require('assert'); +Error.stackTraceLimit = Infinity; + (function foobar() { require('domain'); })(); diff --git a/test/parallel/test-module-prototype-mutation.js b/test/parallel/test-module-prototype-mutation.js index b21dba87b6a..d0149548600 100644 --- a/test/parallel/test-module-prototype-mutation.js +++ b/test/parallel/test-module-prototype-mutation.js @@ -1,12 +1,21 @@ 'use strict'; const common = require('../common'); const fixtures = require('../common/fixtures'); +const { Channel } = require('diagnostics_channel'); const assert = require('assert'); Object.defineProperty(Object.prototype, 'name', { __proto__: null, get: common.mustNotCall('get %Object.prototype%.name'), - set: common.mustNotCall('set %Object.prototype%.name'), + set: function(v) { + // A diagnostic_channel is created to track module loading + // when using `require` or `import`. This class contains a + // `name` property that would cause a false alert for this + // test case. See Channel.prototype.name. + if (!(this instanceof Channel)) { + common.mustNotCall('set %Object.prototype%.name')(v); + } + }, enumerable: false, }); Object.defineProperty(Object.prototype, 'main', { diff --git a/test/parallel/test-repl.js b/test/parallel/test-repl.js index 9b255ed0edd..4d406a8a36c 100644 --- a/test/parallel/test-repl.js +++ b/test/parallel/test-repl.js @@ -577,11 +577,12 @@ const errorTests = [ /^Uncaught Error: Cannot find module 'internal\/repl'/, /^Require stack:/, /^- /, - /^ {4}at .*/, - /^ {4}at .*/, - /^ {4}at .*/, - /^ {4}at .*/, - /^ {4}at .*/, + /^ {4}at .*/, // at Module._resolveFilename + /^ {4}at .*/, // at Module._load + /^ {4}at .*/, // at TracingChannel.traceSync + /^ {4}at .*/, // at wrapModuleLoad + /^ {4}at .*/, // at Module.require + /^ {4}at .*/, // at require " code: 'MODULE_NOT_FOUND',", " requireStack: [ '' ]", '}', diff --git a/test/pseudo-tty/console_colors.js b/test/pseudo-tty/console_colors.js index d819e06c4f1..f9ad3db4a4f 100644 --- a/test/pseudo-tty/console_colors.js +++ b/test/pseudo-tty/console_colors.js @@ -4,6 +4,7 @@ const vm = require('vm'); // Make this test OS-independent by overriding stdio getColorDepth(). process.stdout.getColorDepth = () => 8; process.stderr.getColorDepth = () => 8; +Error.stackTraceLimit = Infinity; console.log({ foo: 'bar' }); console.log('%s q', 'string'); diff --git a/test/pseudo-tty/console_colors.out b/test/pseudo-tty/console_colors.out index 80b14719743..2aaa21fbb7f 100644 --- a/test/pseudo-tty/console_colors.out +++ b/test/pseudo-tty/console_colors.out @@ -13,6 +13,7 @@ foobar [90m at *[39m [90m at *[39m [90m at *[39m +[90m at *[39m Error: Should not ever get here. at Object. [90m(*node_modules*[4m*node_modules*[24m*bar.js:*:*[90m)[39m @@ -22,9 +23,17 @@ Error: Should not ever get here. [90m at *[39m [90m at *[39m [90m at *[39m +[90m at *[39m [90m at *[39m at Object. [90m(*console_colors.js:*:*[90m)[39m [90m at *[39m +[90m at *[39m +[90m at *[39m +[90m at *[39m +[90m at *[39m +[90m at *[39m +[90m at *[39m +[90m at *[39m Error at evalmachine.:*:* @@ -37,3 +46,5 @@ Error [90m at *[39m [90m at *[39m [90m at *[39m +[90m at *[39m +[90m at *[39m diff --git a/test/pseudo-tty/test-fatal-error.out b/test/pseudo-tty/test-fatal-error.out index 7040eb812ce..7809e049fe0 100644 --- a/test/pseudo-tty/test-fatal-error.out +++ b/test/pseudo-tty/test-fatal-error.out @@ -8,7 +8,8 @@ TypeError: foobar [90m at *(node:internal*loader:*:*)[39m [90m at *(node:internal*loader:*:*)[39m [90m at *(node:internal*loader:*:*)[39m -[90m at *(node:internal*loader:*:*)[39m +[90m at *[39m +[90m at *[39m [90m at *[39m [90m at *[39m { bla: [33mtrue[39m diff --git a/test/pseudo-tty/test-trace-sigint.out b/test/pseudo-tty/test-trace-sigint.out index ae6063b7424..6efae6f612f 100644 --- a/test/pseudo-tty/test-trace-sigint.out +++ b/test/pseudo-tty/test-trace-sigint.out @@ -8,3 +8,4 @@ KEYBOARD_INTERRUPT: Script execution was interrupted by `SIGINT` at * at * at * + at *