Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

Revert "src: ignore GCC -Wcast-function-type for v8.h"

Browse Source 
This reverts commit f21cf456bf as this has
now been included in the V8 version being used.

PR-URL: https://github.com/nodejs/node/pull/35758
Refs: f08cbfdc40
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Daniel Bevenius 2020-10-22 17:07:51 +02:00
parent 48d2aca39b
commit f44029e727
2 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/string_bytes.h
View File

@ -26,14 +26,7 @@
// Decodes a v8::Local<v8::String> or Buffer to a raw char*
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif
#include "env-inl.h"
#include <string>

7
test/cctest/test_aliased_buffer.cc
View File

@ -1,11 +1,4 @@
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wcast-function-type"
#endif
#include "v8.h"
#if (__GNUC__ >= 8) && !defined(__clang__)
#pragma GCC diagnostic pop
#endif
#include "aliased_buffer.h"
#include "node_test_fixture.h"