Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

doc,test: enable recursive file watching in Windows

Browse Source 
Recursive file watching is supported by libuv since 1.7.0. Refer
https://github.com/nodejs/node/blob/master/deps/uv/ChangeLog#L126. This
patch notes that in the docs and enables testing this feature. It also
adds proper TAP plugin parsable message for other platforms.

PR-URL: https://github.com/nodejs/node/pull/2649
Fixes: https://github.com/nodejs/node/issues/375
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org>
Reviewed-By: silverwind - Roman Reiss <me@silverwind.io>
This commit is contained in:
Sakthipriyan Vairamani 2015-09-02 14:54:24 +05:30 committed by Rod Vagg
parent 729479f3f4
commit f0a75ab2d3
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/api/fs.markdown
View File

@ -625,9 +625,9 @@ the event.
The `fs.watch` API is not 100% consistent across platforms, and is
unavailable in some situations.
The recursive option is currently supported on OS X. Only FSEvents supports this
type of file watching so it is unlikely any additional platforms will be added
soon.
The recursive option is currently supported on OS X and Windows. Only FSEvents
supports this type of file watching so it is unlikely any additional platforms
will be added soon.
#### Availability

4
test/sequential/test-fs-watch-recursive.js
View File

@ -4,7 +4,7 @@ var assert = require('assert');
var path = require('path');
var fs = require('fs');
if (process.platform === 'darwin') {
if (process.platform === 'darwin' || common.isWindows) {
var watchSeenOne = 0;
var testDir = common.tmpDir;
@ -46,4 +46,6 @@ if (process.platform === 'darwin') {
setTimeout(function() {
fs.writeFileSync(filepathOne, 'world');
}, 10);
} else {
console.log('1..0 # Skipped: recursive option is darwin/windows specific');
}