From ee31c28298ce257847e08b1279909a4a3002866d Mon Sep 17 00:00:00 2001 From: MaleDong Date: Mon, 17 Sep 2018 13:50:09 +0800 Subject: [PATCH] test: remove string literals for strictEquals/notStrictEquals In short: Some unit tests are using string literals to simply tell you a conclusion what's right/wrong BUT not tell you what actually values are. So it's necessary to print them out in the console. Refs: https://github.com/nodejs/node/pull/22849 PR-URL: https://github.com/nodejs/node/pull/22891 Reviewed-By: Daniel Bevenius Reviewed-By: Sakthipriyan Vairamani Reviewed-By: Denys Otrishko Reviewed-By: James M Snell --- test/fixtures/not-main-module.js | 5 ++--- test/parallel/test-async-wrap-trigger-id.js | 12 ++++++------ 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/test/fixtures/not-main-module.js b/test/fixtures/not-main-module.js index f0bae3db157..247868101f9 100644 --- a/test/fixtures/not-main-module.js +++ b/test/fixtures/not-main-module.js @@ -20,6 +20,5 @@ // USE OR OTHER DEALINGS IN THE SOFTWARE. const assert = require('assert'); -assert.notStrictEqual(module, require.main, 'require.main should not == module'); -assert.notStrictEqual(module, process.mainModule, - 'process.mainModule should not === module'); +assert.notStrictEqual(module, require.main); +assert.notStrictEqual(module, process.mainModule); diff --git a/test/parallel/test-async-wrap-trigger-id.js b/test/parallel/test-async-wrap-trigger-id.js index 271fe3b107e..e8b4682b716 100644 --- a/test/parallel/test-async-wrap-trigger-id.js +++ b/test/parallel/test-async-wrap-trigger-id.js @@ -11,18 +11,18 @@ let triggerAsyncId1; process.nextTick(() => { process.nextTick(() => { triggerAsyncId1 = triggerAsyncId(); + // Async resources having different causal ancestry + // should have different triggerAsyncIds assert.notStrictEqual( triggerAsyncId0, - triggerAsyncId1, - 'Async resources having different causal ancestry ' + - 'should have different triggerAsyncIds'); + triggerAsyncId1); }); process.nextTick(() => { const triggerAsyncId2 = triggerAsyncId(); + // Async resources having the same causal ancestry + // should have the same triggerAsyncId assert.strictEqual( triggerAsyncId1, - triggerAsyncId2, - 'Async resources having the same causal ancestry ' + - 'should have the same triggerAsyncId'); + triggerAsyncId2); }); });