From e9904fe49af2b08ea317da93f5684bd0da76582e Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Fri, 11 Oct 2024 15:30:32 +0200 Subject: [PATCH] doc: edit onboarding guide to clarify when mailmap addition is needed PR-URL: https://github.com/nodejs/node/pull/55334 Reviewed-By: Michael Dawson Reviewed-By: Richard Lau Reviewed-By: Moshe Atlow Reviewed-By: Rafael Gonzaga Reviewed-By: Jake Yuesong Li Reviewed-By: Marco Ippolito Reviewed-By: Luigi Pinca --- onboarding.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/onboarding.md b/onboarding.md index 0731161a4c4..bdd266eb527 100644 --- a/onboarding.md +++ b/onboarding.md @@ -216,16 +216,14 @@ needs to be pointed out separately during the onboarding. `git show --format=%B 6669b3857f0f43ee0296eb7ac45086cd907b9e94` * Collaborators are in alphabetical order by GitHub username. * Optionally, include your personal pronouns. -* The PR should include an addition to the - [mailmap](.mailmap) file if the email - being added to the collaborator list does not match the email used for - commits. Otherwise tooling will not see the collaborator as being active and - may suggest removing them. See - [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the - format of the mailmap file. -* Add the `Fixes: ` to the commit message +* Commit, including a `Fixes: ` trailer so that when the commit lands, the nomination issue url will be automatically closed. +* Run `tools/find-inactive-collaborators.mjs`. If that command outputs your name, + amend the commit to include an addition to the [mailmap](.mailmap) file. See + [gitmailmap](https://git-scm.com/docs/gitmailmap) for information on the + format of the mailmap file. +* Push the commit to your own fork. * Label your pull request with the `doc`, `notable-change`, and `fast-track` labels. The `fast-track` label should cause the Node.js GitHub bot to post a comment in the pull request asking collaborators to approve the pull request