Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: refactor pummel/test-net-many-clients

Browse Source 
* Use port 0 instead of `common.PORT`.
* Reduce `concurrent` from 100 to 50 and `connections_per_client` from 5
  to 3. This is to avoid side effects from other tests. Prior to this
  change, running this along with test-keep-alive would result in
  failures on my local setup, apparently due to network throttling.
* Remove unnecessary `console.log()` and improve remaining
  `console.log()` to provide clearer information.

PR-URL: https://github.com/nodejs/node/pull/25485
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This commit is contained in:
Rich Trott 2019-01-13 20:58:06 -08:00
parent b39234a4a8
commit e675d4bd2b
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
test/pummel/test-net-many-clients.js
View File

@ -20,14 +20,14 @@
// USE OR OTHER DEALINGS IN THE SOFTWARE.
'use strict';
const common = require('../common');
require('../common');
const assert = require('assert');
const net = require('net');
// settings
const bytes = 1024 * 40;
const concurrency = 100;
const connections_per_client = 5;
const concurrency = 50;
const connections_per_client = 3;
// measured
let total_connections = 0;
@ -35,15 +35,14 @@ let total_connections = 0;
const body = 'C'.repeat(bytes);
const server = net.createServer(function(c) {
console.log('connected');
total_connections++;
console.log('#');
console.log('connected', total_connections);
c.write(body);
c.end();
});
function runClient(callback) {
const client = net.createConnection(common.PORT);
function runClient(port, callback) {
const client = net.createConnection(port);
client.connections = 0;
@ -79,17 +78,17 @@ function runClient(callback) {
assert.ok(!client.fd);
if (this.connections < connections_per_client) {
this.connect(common.PORT);
this.connect(port);
} else {
callback();
}
});
}
server.listen(common.PORT, function() {
server.listen(0, function() {
let finished_clients = 0;
for (let i = 0; i < concurrency; i++) {
runClient(function() {
runClient(server.address().port, function() {
if (++finished_clients === concurrency) server.close();
});
}