Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

lib: further simplify assertions in vm/module

Browse Source 
Refs: https://github.com/nodejs/node/pull/30755

PR-URL: https://github.com/nodejs/node/pull/30815
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Anna Henningsen 2019-12-06 01:09:09 +01:00 committed by Myles Borins
parent 05041d3ab1
commit db109e85d6
No known key found for this signature in database
GPG Key ID: 933B01F40B5CA946
1 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
lib/internal/vm/module.js
View File

@ -1,6 +1,6 @@
'use strict';
const { fail } = require('internal/assert');
const assert = require('internal/assert');
const {
ArrayIsArray,
ObjectCreate,
@ -59,11 +59,6 @@ const kContext = Symbol('kContext');
const kPerContextModuleId = Symbol('kPerContextModuleId');
const kLink = Symbol('kLink');
function failIfDebug() {
if (process.features.debug === false) return;
fail('VM Modules');
}
class Module {
constructor(options) {
emitExperimentalWarning('VM Modules');
@ -119,12 +114,11 @@ class Module {
importModuleDynamicallyWrap(options.importModuleDynamically) :
undefined,
});
} else if (syntheticEvaluationSteps) {
} else {
assert(syntheticEvaluationSteps);
this[kWrap] = new ModuleWrap(identifier, context,
syntheticExportNames,
syntheticEvaluationSteps);
} else {
failIfDebug();
}
wrapToModuleMap.set(this[kWrap], this);
@ -380,7 +374,9 @@ class SyntheticModule extends Module {
identifier,
});
this[kLink] = () => this[kWrap].link(() => { failIfDebug(); });
this[kLink] = () => this[kWrap].link(() => {
assert.fail('link callback should not be called');
});
}
setExport(name, value) {