Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: delay child exit in AIX for pseudo-tty tests

Browse Source 
The tests in pseudo-tty takes the form of child node writing some data
and exiting, while parent python consume them through pseudo tty
implementations, and validate the result.

While there is no synchronization between child and parent, this works
for most platforms, except AIX, where the child exits even before the
parent could setup the read loop, under race conditions

Fixing the race condition is ideally done through sending ACK messages
to and forth, but involves massive changes and have side effect. The
workaround is to address them in AIX alone, by adding a reasonable
delay.

PR-URL: https://github.com/nodejs/node/pull/11715
Fixes: https://github.com/nodejs/node/issues/7973
Fixes: https://github.com/nodejs/node/issues/9765
Fixes: https://github.com/nodejs/node/issues/11541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This commit is contained in:
Gireesh Punathil 2017-03-06 10:24:07 -05:00 committed by Gibson Fahnestock
parent d099f8e317
commit d631af59c0
No known key found for this signature in database
GPG Key ID: B01FBB92821C587A
4 changed files with 19 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
test/pseudo-tty/no_dropped_stdio.js
View File

@ -1,7 +1,7 @@
// https://github.com/nodejs/node/issues/6456#issuecomment-219320599
// https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd
'use strict';
require('../common');
const common = require('../common');
// 1000 bytes wrapped at 50 columns
// \n turns into a double-byte character
@ -11,5 +11,9 @@ let out = ('o'.repeat(48) + '\n').repeat(20);
// This results in 1025 bytes, just enough to overflow the 1kb OS X TTY buffer.
out += 'o'.repeat(24) + 'O';
process.stdout.write(out);
process.exit(0);
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.stdout.write(out);
process.exit(0);
}, common.isAix ? 200 : 0);

10
test/pseudo-tty/no_interleaved_stdio.js
View File

@ -1,7 +1,7 @@
// https://github.com/nodejs/node/issues/6456#issuecomment-219320599
// https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd
'use strict';
require('../common');
const common = require('../common');
// 1000 bytes wrapped at 50 columns
// \n turns into a double-byte character
@ -13,5 +13,9 @@ out += 'o'.repeat(24) + 'O';
const err = '__This is some stderr__';
process.stdout.write(out);
process.stderr.write(err);
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.stdout.write(out);
process.stderr.write(err);
}, common.isAix ? 200 : 0);

3
test/pseudo-tty/pseudo-tty.status
View File

@ -1,8 +1,5 @@
prefix pseudo-tty
[$system==aix]
# test issue only, covered under https://github.com/nodejs/node/issues/7973
no_dropped_stdio : SKIP
no_interleaved_stdio : SKIP
# being investigated under https://github.com/nodejs/node/issues/9728
test-tty-wrap : FAIL, PASS

6
test/pseudo-tty/test-stderr-stdout-handle-sigwinch.js
View File

@ -27,4 +27,8 @@ process.stdout._refreshSize = wrap(originalRefreshSizeStdout,
process.stdout,
'calling stdout._refreshSize');
process.emit('SIGWINCH');
// In AIX, the child exits even before the python parent
// can setup the readloop. Provide a reasonable delay.
setTimeout(function() {
process.emit('SIGWINCH');
}, common.isAix ? 200 : 0);