Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

wasi: improve use of primordials

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/31212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
cjihrig 2020-01-06 00:23:50 -05:00
parent e908323b7e
commit b8922e8924
No known key found for this signature in database
GPG Key ID: 7434390BDBE9B9C5
1 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
lib/wasi.js
View File

@ -2,10 +2,10 @@
/* global WebAssembly */ /* global WebAssembly */
const { const {
ArrayIsArray, ArrayIsArray,
ArrayPrototypeForEach,
ArrayPrototypeMap, ArrayPrototypeMap,
ArrayPrototypePush,
FunctionPrototypeBind, FunctionPrototypeBind,
ObjectKeys, ObjectEntries,
Symbol, Symbol,
} = primordials; } = primordials;
@ -40,7 +40,7 @@ class WASI {
for (const key in env) { for (const key in env) {
const value = env[key]; const value = env[key];
if (value !== undefined) if (value !== undefined)
envPairs.push(`${key}=${value}`); ArrayPrototypePush(envPairs, `${key}=${value}`);
} }
} else if (env !== undefined) { } else if (env !== undefined) {
throw new ERR_INVALID_ARG_TYPE('options.env', 'Object', env); throw new ERR_INVALID_ARG_TYPE('options.env', 'Object', env);
@ -49,10 +49,9 @@ class WASI {
const preopenArray = []; const preopenArray = [];
if (typeof preopens === 'object' && preopens !== null) { if (typeof preopens === 'object' && preopens !== null) {
ArrayPrototypeForEach(ObjectKeys(preopens), (key) => { for (const [key, value] of ObjectEntries(preopens)) {
preopenArray.push(String(key)); ArrayPrototypePush(preopenArray, String(key), String(value));
preopenArray.push(String(preopens[key])); }
});
} else if (preopens !== undefined) { } else if (preopens !== undefined) {
throw new ERR_INVALID_ARG_TYPE('options.preopens', 'Object', preopens); throw new ERR_INVALID_ARG_TYPE('options.preopens', 'Object', preopens);
} }