Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

fs: move method definition from header

Browse Source 
We are defining the definition of function in the header file itself. It
should be defined in the source file instead of the header file.

PR-URL: https://github.com/nodejs/node/pull/36256
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This commit is contained in:
Yash Ladha 2020-11-25 13:16:13 +05:30 committed by Rich Trott
parent 6ca7312f0e
commit 9bf12df344
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/node_file.cc
View File

@ -2534,6 +2534,9 @@ void Initialize(Local<Object> target,
use_promises_symbol).Check();
}
BindingData* FSReqBase::binding_data() {
return binding_data_.get();
}
} // namespace fs
} // end namespace node

2
src/node_file.h
View File

@ -109,7 +109,7 @@ class FSReqBase : public ReqWrap<uv_fs_t> {
void MemoryInfo(MemoryTracker* tracker) const override;
BindingData* binding_data() { return binding_data_.get(); }
BindingData* binding_data();
private:
std::unique_ptr<FSContinuationData> continuation_data_;