Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

benchmark: rename count to n

Browse Source 
It's a common approach to use n as number of iterations over the
benchmark. Changing it from count to n will also make
./node benchmark/run.js --set n=X more meaningful among other
benchmarks

PR-URL: https://github.com/nodejs/node/pull/54271
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This commit is contained in:
Rafael Gonzaga 2024-08-10 17:07:54 -03:00 committed by GitHub
parent b49019eed6
commit 9b3d22dcf6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
benchmark/misc/startup-cli-version.js
View File

@ -18,12 +18,12 @@ const availableCli = [
].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli))); ].filter((cli) => existsSync(path.resolve(__dirname, '../../', cli)));
const bench = common.createBenchmark(main, { const bench = common.createBenchmark(main, {
cli: availableCli, cli: availableCli,
count: [30], n: [30],
}); });
function spawnProcess(cli, bench, state) { function spawnProcess(cli, bench, state) {
const cmd = process.execPath || process.argv[0]; const cmd = process.execPath || process.argv[0];
while (state.finished < state.count) { while (state.finished < state.n) {
const child = spawnSync(cmd, [cli, '--version'], { const child = spawnSync(cmd, [cli, '--version'], {
env: { npm_config_loglevel: 'silent', ...process.env }, env: { npm_config_loglevel: 'silent', ...process.env },
}); });
@ -41,15 +41,15 @@ function spawnProcess(cli, bench, state) {
bench.start(); bench.start();
} }
if (state.finished === state.count) { if (state.finished === state.n) {
bench.end(state.count); bench.end(state.n);
} }
} }
} }
function main({ count, cli }) { function main({ n, cli }) {
cli = path.resolve(__dirname, '../../', cli); cli = path.resolve(__dirname, '../../', cli);
const warmup = 3; const warmup = 3;
const state = { count, finished: -warmup }; const state = { n, finished: -warmup };
spawnProcess(cli, bench, state); spawnProcess(cli, bench, state);
} }

16
benchmark/misc/startup-core.js
View File

@ -12,12 +12,12 @@ const bench = common.createBenchmark(main, {
'test/fixtures/snapshot/typescript', 'test/fixtures/snapshot/typescript',
], ],
mode: ['process', 'worker'], mode: ['process', 'worker'],
count: [30], n: [30],
}); });
function spawnProcess(script, bench, state) { function spawnProcess(script, bench, state) {
const cmd = process.execPath || process.argv[0]; const cmd = process.execPath || process.argv[0];
while (state.finished < state.count) { while (state.finished < state.n) {
const child = spawnSync(cmd, [script]); const child = spawnSync(cmd, [script]);
if (child.status !== 0) { if (child.status !== 0) {
console.log('---- STDOUT ----'); console.log('---- STDOUT ----');
@ -32,8 +32,8 @@ function spawnProcess(script, bench, state) {
bench.start(); bench.start();
} }
if (state.finished === state.count) { if (state.finished === state.n) {
bench.end(state.count); bench.end(state.n);
} }
} }
} }
@ -49,18 +49,18 @@ function spawnWorker(script, bench, state) {
// Finished warmup. // Finished warmup.
bench.start(); bench.start();
} }
if (state.finished < state.count) { if (state.finished < state.n) {
spawnWorker(script, bench, state); spawnWorker(script, bench, state);
} else { } else {
bench.end(state.count); bench.end(state.n);
} }
}); });
} }
function main({ count, script, mode }) { function main({ n, script, mode }) {
script = path.resolve(__dirname, '../../', `${script}.js`); script = path.resolve(__dirname, '../../', `${script}.js`);
const warmup = 3; const warmup = 3;
const state = { count, finished: -warmup }; const state = { n, finished: -warmup };
if (mode === 'worker') { if (mode === 'worker') {
Worker = require('worker_threads').Worker; Worker = require('worker_threads').Worker;
spawnWorker(script, bench, state); spawnWorker(script, bench, state);