Nodejs/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2024-11-21 10:59:27 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

crypto: Make Decipher._flush() emit errors.

Browse Source 
When Decipher processes a stream using an incorrect key, the
DecipherFinal() method throws an unhandled exception at the end of the
stream.
This commit is contained in:
Kai Groner 2013-04-18 19:01:14 -04:00 committed by Fedor Indutny
parent b371d4ae8f
commit 98be8df571
2 changed files with 21 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/crypto.js
View File

@ -263,7 +263,12 @@ Cipher.prototype._transform = function(chunk, encoding, callback) {
};
Cipher.prototype._flush = function(callback) {
this.push(this._binding.final());
try {
this.push(this._binding.final());
} catch (e) {
callback(e);
return;
}
callback();
};

15
test/simple/test-crypto-stream.js
View File

@ -60,3 +60,18 @@ crypto.createHash('md5').unpipe({});
crypto.createHash('md5').setEncoding('utf8');
crypto.createHash('md5').pause();
crypto.createHash('md5').resume();
// Decipher._flush() should emit an error event, not an exception.
var key = new Buffer('48fb56eb10ffeb13fc0ef551bbca3b1b', 'hex'),
badkey = new Buffer('12341234123412341234123412341234', 'hex'),
iv = new Buffer('6d358219d1f488f5f4eb12820a66d146', 'hex'),
cipher = crypto.createCipheriv('aes-128-cbc', key, iv),
decipher = crypto.createDecipheriv('aes-128-cbc', badkey, iv);
cipher.pipe(decipher)
.on('error', common.mustCall(function end(err) {
// TypeError: error:06065064:digital envelope routines:EVP_DecryptFinal_ex:bad decrypt
assert(/:06065064:/.test(err));
}));
cipher.end('Papaya!'); // Should not cause an unhandled exception.